Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename header action to playground #180183

Conversation

Samiul-TheSoccerFan
Copy link
Contributor

Summary

  • Remove Search Applications from indices, connectors and crawler page
  • Added a new button to redirect to playground
  • catch the index if available in indices or connectors page
  • display that index as selected

Display Playground in indices:

Screenshot 2024-04-05 at 8 59 48 AM

Route to playground from navbar

Screenshot 2024-04-05 at 8 59 34 AM

Route to playground from indices

Screenshot 2024-04-05 at 8 59 09 AM

Route to playground from indices

Screenshot 2024-04-05 at 8 59 20 AM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@Samiul-TheSoccerFan Samiul-TheSoccerFan added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.14.0 labels Apr 5, 2024
@Samiul-TheSoccerFan Samiul-TheSoccerFan force-pushed the rename-header-action-to-playground branch from 38c8132 to 8e0dda0 Compare April 8, 2024 15:50
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #52 / GET /internal/cloud_security_posture/stats KSPM Compliance Dashboard Stats API should return KSPM benchmarks V2
  • [job] [logs] FTR Configs #33 / serverless observability UI Serverless Observability Cases Cases persistable attachments lens visualization adds lens visualization to a new case

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2266 2264 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.7MB 2.7MB -1.8KB
searchPlayground 150.7KB 150.8KB +92.0B
total -1.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
searchPlayground 0 1 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Samiul-TheSoccerFan Samiul-TheSoccerFan merged commit 801c7e5 into elastic:main Apr 8, 2024
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 8, 2024
@Samiul-TheSoccerFan Samiul-TheSoccerFan deleted the rename-header-action-to-playground branch April 8, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants