[RAM][HTTP Versioning] Version Internal and Public Find Rules Route #180654
Conversation
JiaweiWu
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
| ), | ||
| filterConsumers: schema.maybe(schema.arrayOf(schema.string())), | ||
| }, | ||
| { unknowns: 'allow' } |
There was a problem hiding this comment.
What is the reason of allowing unknowns?
There was a problem hiding this comment.
security solution is passing through some props into this method that is passed through to the saved object client. These props are not listed as supported types to the find function. I dont think the props are doing anything but I was afraid to remove it.
There was a problem hiding this comment.
These props are not listed as supported types to the find function
But they use it anyway? How TS does not throw an error? Did we support it in the first place?
There was a problem hiding this comment.
Well it doesn't cause errors because we pull off all of the fields that the method uses. So extra props are just discarded. However we now validate the params so without passthrough, it starts to throw.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing exports
History
To update your PR or re-run it, just comment with: |
Summary
Issue: #180551
Parent Issue: #157883
Versions the internal and public find API routes. Adds Input validation as well.
Checklist