Upgrade EUI to v94.2.1 #182023
Merged
Upgrade EUI to v94.2.1 #182023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@tkajtoch Please handle the EuiFlex* and |
cee-chen
added
release_note:skip
|
buildkite test this |
- accounts for a11y change to no longer auto-focus the accordion content
…y `label` not being a string
…ges to add the new `optionMatcher` prop
|
/ci |
|
Pinging @elastic/eui-team (EUI) |
jbudz
approved these changes
May 1, 2024
pgayvallet
approved these changes
May 2, 2024
azasypkin
approved these changes
May 2, 2024
sebelga
approved these changes
May 2, 2024
nickofthyme
approved these changes
May 2, 2024
cqliu1
approved these changes
May 2, 2024
gergoabraham
approved these changes
May 3, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
cee-chen
added a commit
that referenced
this pull request
May 9, 2024
👋 Hey y'all ent search folks! I missed this fix/update update in our latest EUI upgrade (#182023). It's directly related to this change in EUI v94.2.0: > - Fixed an `EuiPageTemplate` bug where prop updates would not cascade down to child sections ([#7648](elastic/eui#7648)) > - To cascade props down to the sidebar, `EuiPageTemplate` now explicitly requires using the `EuiPageTemplate.Sidebar` rather than `EuiPageSidebar` In general, it's also a best practice to use EuiPageTemplate's namespaced children instead of the direct `EuiPage*` components (which are meant for direct usage within a`EuiPage` component instead), so I've made similar changes to your code as well. I would suggest pulling down this PR to QA that your page still looks as expected/as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v94.1.0-backport.0⏩v94.2.1-backport.0Questions? Please see our Kibana upgrade FAQ.
v94.2.1-backport.0This is a backport release only intended for use by Kibana.
EuiFlexGroup/EuiFlexItemcomponentprop feature due to Kibana typing issuesv94.2.1Bug fixes
EuiTabbedContentedge case bug that occurred when updated with a completely different set oftabs(#7713)@storybook/testdependency to be listed indevDependenciesand notdependencies(#7719)v94.2.0getDefaultEuiMarkdownPlugins()to allow excluding the following plugins in addition totooltip: (#7676)checkboxlinkValidatorlineBreaksemojiEuiSelectable'sisPreFilteredprop to allow passing a configuration object, which allows disabling search highlighting in addition to search filtering (#7683)EuiFlexGroupandEuiFlexItemprop types to support passing any valid React component type to thecomponentprop and ensure proper type checking of the extra props forwarded to thecomponent. (#7688)EuiSearchBarto allow the@special character in query string searches (#7702)optionMatcherprop toEuiSelectableandEuiComboBoxallowing passing a custom option matcher function to these components and controlling option filtering for given search string (#7709)Bug fixes
EuiPageTemplatebug where prop updates would not cascade down to child sections (#7648)EuiPageTemplatenow explicitly requires using theEuiPageTemplate.Sidebarrather thanEuiPageSidebarEuiFieldNumber's typing to accept an icon configuration shape (#7666)EuiFieldTextandEuiFieldNumberto render the correct paddings for icon shapes set toside: 'right'(#7666)EuiFieldTextandEuiFieldNumberto fully ignoreicon/prepend/appendwhencontrolOnlyis set to true (#7666)EuiColorPicker's input not setting the correct right padding for the number of icons displayed (#7666)EuiRanges withshowInput: (#7678)append/prependlabels no longer cause a background bugEuiTableRowCells with therowheader scope (#7681)toolTipPropstype onEuiSuperUpdateButtonto usePartial<EuiToolTipProps>(#7692)popperPropsonEuiDatePicker(#7694)EuiDataGrids withleadingControlColumnswhen moving columns to the left/right (#7701) (#7698)EuiSuperDatePickerto validate date string with respect of locale onEuiAbsoluteTab. (#7705)EuiSuperDatePicker's absolute tab on small mobile screens (#7708)FieldValueSelectionFiltercomponent (#7718)Dependency updates
@hello-pangea/dndto v16.6.0 (#7599)remark-rehypeto v8.1.0 (#7601)Accessibility
EuiBasicTableandEuiInMemoryTable's selection checkboxes to have unique aria-labels per row (#7672)aria-valuetextattributes toEuiRanges with tick labels for improved screen reader UX (#7675)EuiAccordionto keep focus on accordion trigger instead of moving to content on click/keypress (#7696)aria-disabledattribute toEuiHorizontalStepswhen status is "disabled" (#7699)