Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Mitigate typecheck timeout issues #183257

Merged
merged 4 commits into from
May 13, 2024
Merged

[CI] Mitigate typecheck timeout issues #183257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4066abb
chore: remove type_check.yml, it was used conditionally in pipeline.t…
delanni May 13, 2024
5859098
chore: remove type_check_with_status, it was used as a hack to work a…
delanni May 13, 2024
c9f2738
chore: bump typecheck timeouts to 70m
delanni May 13, 2024
3a3377e
chore: remove check_types_commits.sh, as it's no longer used
delanni May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .buildkite/pipelines/build_api_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
env:
PUBLISH_API_DOCS_CHANGES: 'true'
steps:
- command: .buildkite/scripts/steps/api_docs/type_check_with_status.sh
label: Run scripts/type_check
key: type_check
- command: .buildkite/scripts/steps/check_types.sh
label: 'Check types'
key: check_types
agents:
image: family/kibana-ubuntu-2004
imageProject: elastic-images-prod
provider: gcp
machineType: n2-standard-4
preemptible: true
timeout_in_minutes: 50
timeout_in_minutes: 70

- command: .buildkite/scripts/steps/api_docs/build_api_docs.sh
label: 'Build API Docs'
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/pipelines/on_merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ steps:
label: 'Check Types'
agents:
queue: n2-4-spot
timeout_in_minutes: 60
timeout_in_minutes: 70
retry:
automatic:
- exit_status: '-1'
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/pipelines/pull_request/base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ steps:
agents:
queue: n2-4-spot
key: check_types
timeout_in_minutes: 60
timeout_in_minutes: 70
retry:
automatic:
- exit_status: '-1'
Expand Down
10 changes: 0 additions & 10 deletions .buildkite/pipelines/pull_request/type_check.yml
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions .buildkite/scripts/steps/api_docs/type_check_with_status.sh
View file
Open in desktop

This file was deleted.

191 changes: 0 additions & 191 deletions .buildkite/scripts/steps/check_types_commits.sh
View file
Open in desktop

This file was deleted.