Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover][DocViewer] Adjust bottom margin in flyout #183478

Merged
merged 6 commits into from
May 17, 2024
Merged

[Discover][DocViewer] Adjust bottom margin in flyout #183478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d05047c
[Discover] Fix JSON view height in DocViewer
jughosta May 15, 2024
423aaa3
[Discover] Add a comment
jughosta May 15, 2024
f33005d
[Discover] Revert padding change
jughosta May 15, 2024
6e3873b
[Discover] Update tests
jughosta May 15, 2024
e5f2156
Merge branch 'main' into adjust-bottom-margin-in-flyout
jughosta May 15, 2024
8ebb4ff
Merge branch 'main' into adjust-bottom-margin-in-flyout
jughosta May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/plugins/unified_doc_viewer/public/components/doc_viewer_source/get_height.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import { monaco } from '@kbn/monaco';
import { getHeight } from './get_height';
import { MARGIN_BOTTOM } from './source';

describe('getHeight', () => {
Object.defineProperty(window, 'innerHeight', { writable: true, configurable: true, value: 500 });
Expand All @@ -32,7 +33,7 @@ describe('getHeight', () => {
const monacoMock = getMonacoMock(500, 0);

const height = getHeight(monacoMock, true);
expect(height).toBe(475);
expect(height).toBe(500 - MARGIN_BOTTOM);
});

test('when using document explorer, returning the available height in the flyout has a minimun guarenteed height', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/unified_doc_viewer/public/components/doc_viewer_source/source.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ interface SourceViewerProps {
// inline limitation was necessary to enable virtualized scrolling, which improves performance
export const MAX_LINES_CLASSIC_TABLE = 500;
// Displayed margin of the code editor to the window bottom when rendered in the document explorer flyout
export const MARGIN_BOTTOM = 25;
export const MARGIN_BOTTOM = 80; // DocViewer flyout has a footer
// Minimum height for the source content to guarantee minimum space when the flyout is scrollable.
export const MIN_HEIGHT = 400;

Expand Down