-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle situations without data #1849
Conversation
…in cases of the area chart when there is only one point of data
I noticed a weird bug with tile maps on the dashboard, this seems to result from the visualization being hidden.
The issue is in visualizations/tile_map:
Refreshing the view (by hitting enter in the query bar again) will bring it back. |
The solution I quickly tried to put in place on Friday was:
This solution seemed to be working on friday, but after trying to write tests proving that it worked I noticed a flaw: both the vislib and template visualizations need to render asynchronously, and can't always throw their errors to the visualize directive. Currently, the async rendering is caused by the "resize" event, triggered by the resize checker in the vislib. In the future, I imagine there will be template visualizations that will do async rendering and we should have a good story for those situation as well. This means that we need to do something different. Here are my two ideas:
1+2=3. as a third option, we could implement both solutions in the respective renderbots, and then have the renderbots communicate the error to the visualize directive. While this is likely to satisfy the requirements we have with a fairly flexible solution, it feels like a lot of work just to implement error handling at a higher/shard point. Perhaps there is an easier way to implement it, which will work for both the vislib and template visualizations, which wouldn't require a lot of duplicate code? @rashidkpc @w33ble @stormpython @jthomassie @simianhacker @lukasolson Ideas? |
Closes #1847
Provides a new error type and handling for when there isn't enough data to create a visualization