-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency @elastic/charts to v66 (main) #185906
Conversation
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
@nickofthyme I'm not sure why the FT is failing here:
I've checked locally and the metric DOM has the |
@nickofthyme I've changed the way we extract the text from the DOM element. The converted Goal to a Metric shows the value like this (that is acceptable). The problem is that the method The text is anyway fully available in the DOM there because getting it from |
@elastic/obs-ux-infra_services-team can you do a quick CO review? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@elastic/charts](https://github.com/elastic/elastic-charts) | [`65.2.0` -> `66.0.3`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/65.2.0/66.0.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@elastic%2fcharts/66.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@elastic%2fcharts/66.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@elastic%2fcharts/65.2.0/66.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@elastic%2fcharts/65.2.0/66.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>elastic/elastic-charts (@&elastic#8203;elastic/charts)</summary> ### [`v66.0.3`](https://github.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6603-2024-06-18) [Compare Source](https://github.com/elastic/elastic-charts/compare/v66.0.0...v66.0.3) ##### Bug Fixes - correct median copy in legend values ([elastic#2467](elastic/elastic-charts#2467)) ([0476a64](elastic/elastic-charts@0476a64)) ### [`v66.0.2`](https://github.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6602-2024-06-12) [Compare Source](https://github.com/elastic/elastic-charts/compare/v66.0.0...v66.0.2) ##### Features - point style accessor for isolated points ([elastic#2464](elastic/elastic-charts#2464)) ([ee7f529](elastic/elastic-charts@ee7f529)) ### [`v66.0.0`](https://github.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6600-2024-06-10) [Compare Source](https://github.com/elastic/elastic-charts/compare/v65.2.0...v66.0.0) ##### Features - **Metric:** style enhancements ([#&elastic#8203;2437](https://github.com/elastic/elastic-charts/issues/2437)) ([0686596](https://github.com/elastic/elastic-charts/commit/0686596b44fd9cac00955478179597c5b4bd9d91)) ##### Performance Improvements - replace spread with concat where useful ([#&elastic#8203;2446](https://github.com/elastic/elastic-charts/issues/2446)) ([078b490](https://github.com/elastic/elastic-charts/commit/078b4905131fcf368a25bcadcb53e414d634daea)) ##### BREAKING CHANGES - **Metric:** The `MetricStyle.text.darkColor` and `MetricStyle.text.lightColor` are now `MetricStyle.textDarkColor` and `MetricStyle.textLightColor`, respectively. This PR also includes minor overall style changes to the text breakpoints of the `Metric` chart. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/elastic/kibana). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlZpc3VhbGl6YXRpb25zIiwiYmFja3BvcnQ6c2tpcCIsInJlbGVhc2Vfbm90ZTpza2lwIl19--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co> Co-authored-by: nickofthyme <nicholas.partridge@elastic.co>
This PR contains the following updates:
65.2.0
->66.0.3
Release Notes
elastic/elastic-charts (@elastic/charts)
v66.0.3
Compare Source
Bug Fixes
v66.0.2
Compare Source
Features
v66.0.0
Compare Source
Features
Performance Improvements
BREAKING CHANGES
MetricStyle.text.darkColor
andMetricStyle.text.lightColor
are nowMetricStyle.textDarkColor
andMetricStyle.textLightColor
, respectively. This PR also includes minor overall style changes to the text breakpoints of theMetric
chart.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.