Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @elastic/charts to v66 (main) #185906

Merged
merged 11 commits into from
Jun 21, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 10, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/charts 65.2.0 -> 66.0.3 age adoption passing confidence

Release Notes

elastic/elastic-charts (@​elastic/charts)

v66.0.3

Compare Source

Bug Fixes

v66.0.2

Compare Source

Features
  • point style accessor for isolated points (#2464) (ee7f529)

v66.0.0

Compare Source

Features
Performance Improvements
BREAKING CHANGES
  • Metric: The MetricStyle.text.darkColor and MetricStyle.text.lightColor are now MetricStyle.textDarkColor and MetricStyle.textLightColor, respectively. This PR also includes minor overall style changes to the text breakpoints of the Metric chart.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@markov00 markov00 requested a review from a team as a code owner June 11, 2024 10:36
Copy link
Contributor Author

renovate bot commented Jun 11, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@markov00
Copy link
Member

@nickofthyme I'm not sure why the FT is failing here:

 actual: '[\n' +
    '  {\n' +
    '    "color": "rgba(255, 255, 255, 1)"\n' +
    '    "extraText": ""\n' +
    '    "showingBar": true\n' +
    '    "showingTrendline": false\n' +
    '    "subtitle": [undefined]\n' +
    '    "title": "Average machine.ram"\n' +
    '    "trendlineColor": [undefined]\n' +
    '    "value": "131,040,360.81"\n' +
    '  }\n' +
    ']',
  expected: '[\n' +
    '  {\n' +
    '    "color": "rgba(255, 255, 255, 1)"\n' +
    '    "extraText": ""\n' +
    '    "showingBar": true\n' +
    '    "showingTrendline": false\n' +
    '    "subtitle": [undefined]\n' +
    '    "title": "Average machine.ram"\n' +
    '    "trendlineColor": [undefined]\n' +
    '    "value": "131,040,360.81%"\n' +
    '  }\n' +

I've checked locally and the metric DOM has the % at the end of the value. Your changes haven't impacted that part, so I don't fully understand what is going on here

@markov00
Copy link
Member

markov00 commented Jun 13, 2024

@nickofthyme I've changed the way we extract the text from the DOM element. The converted Goal to a Metric shows the value like this (that is acceptable). The problem is that the method getVisibleText works a bit weirdly and seems to pick up the text only on partially visible DOM elements, so in this case just the first Text node of the value element, but not the % that is on a sub-span element.
I'm saying that because the real "Visible" text should be 131,040,3 but the returned value is 131,040,360.81. So I believe there is something going on there with some heuristics on what to consider "visible" with this method.
The other possibility is that the extract the "Visible" text by double-clicking the text and copying the selected one. In this case I tried and it seems to select only the first part, without the % sign.

The text is anyway fully available in the DOM there because getting it from innerText attribute or textContent returns correctly the expected value.

Screenshot 2024-06-13 at 14 57 28

@nickofthyme nickofthyme requested a review from a team as a code owner June 18, 2024 17:54
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 18, 2024
@nickofthyme
Copy link
Contributor

nickofthyme commented Jun 19, 2024

@elastic/obs-ux-infra_services-team can you do a quick CO review? Thanks!

@jennypavlova jennypavlova self-requested a review June 20, 2024 13:16
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickofthyme nickofthyme enabled auto-merge (squash) June 20, 2024 21:21
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 21, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 415.3KB 417.3KB +2.0KB
kbnUiSharedDeps-npmDll 6.0MB 6.0MB +1.8KB
total +3.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme nickofthyme merged commit e969602 into main Jun 21, 2024
41 checks passed
@nickofthyme nickofthyme deleted the renovate/main-@elasticcharts branch June 21, 2024 21:09
bhapas pushed a commit to bhapas/kibana that referenced this pull request Jun 24, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@elastic/charts](https://github.com/elastic/elastic-charts) |
[`65.2.0` ->
`66.0.3`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/65.2.0/66.0.3)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@elastic%2fcharts/66.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@elastic%2fcharts/66.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@elastic%2fcharts/65.2.0/66.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@elastic%2fcharts/65.2.0/66.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>elastic/elastic-charts (@&elastic#8203;elastic/charts)</summary>

###
[`v66.0.3`](https://github.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6603-2024-06-18)

[Compare
Source](https://github.com/elastic/elastic-charts/compare/v66.0.0...v66.0.3)

##### Bug Fixes

- correct median copy in legend values
([elastic#2467](elastic/elastic-charts#2467))
([0476a64](elastic/elastic-charts@0476a64))

###
[`v66.0.2`](https://github.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6602-2024-06-12)

[Compare
Source](https://github.com/elastic/elastic-charts/compare/v66.0.0...v66.0.2)

##### Features

- point style accessor for isolated points
([elastic#2464](elastic/elastic-charts#2464))
([ee7f529](elastic/elastic-charts@ee7f529))

###
[`v66.0.0`](https://github.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6600-2024-06-10)

[Compare
Source](https://github.com/elastic/elastic-charts/compare/v65.2.0...v66.0.0)

##### Features

- **Metric:** style enhancements
([#&elastic#8203;2437](https://github.com/elastic/elastic-charts/issues/2437))
([0686596](https://github.com/elastic/elastic-charts/commit/0686596b44fd9cac00955478179597c5b4bd9d91))

##### Performance Improvements

- replace spread with concat where useful
([#&elastic#8203;2446](https://github.com/elastic/elastic-charts/issues/2446))
([078b490](https://github.com/elastic/elastic-charts/commit/078b4905131fcf368a25bcadcb53e414d634daea))

##### BREAKING CHANGES

- **Metric:** The `MetricStyle.text.darkColor` and
`MetricStyle.text.lightColor` are now `MetricStyle.textDarkColor` and
`MetricStyle.textLightColor`, respectively. This PR also includes minor
overall style changes to the text breakpoints of the `Metric` chart.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/elastic/kibana).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlZpc3VhbGl6YXRpb25zIiwiYmFja3BvcnQ6c2tpcCIsInJlbGVhc2Vfbm90ZTpza2lwIl19-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
Co-authored-by: nickofthyme <nicholas.partridge@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants