chore(NA): upgrade typescript into v5.1.6

.buildkite/package.json

@@ -26,8 +26,8 @@
     "chai": "^4.3.10",
     "mocha": "^10.3.0",
     "nock": "^12.0.2",
-    "ts-node": "^10.7.0",
-    "typescript": "^4.6.4"
+    "ts-node": "^10.9.2",
+    "typescript": "^5.1.6"
   },
   "imports": {
     "#pipeline-utils": "./pipeline-utils/index.ts",

package.json

@@ -91,7 +91,8 @@
     "**/react-intl/**/@types/react": "^17.0.45",
     "**/remark-parse/trim": "1.0.1",
     "**/sharp": "0.32.6",
-    "**/typescript": "4.9.5",
+    "**/typescript": "5.1.6",
+    "@storybook/react-docgen-typescript-plugin": "1.0.6--canary.9.cd77847.0",
     "globby/fast-glob": "^3.2.11"
   },
   "dependencies": {
@@ -1419,7 +1420,6 @@
     "@storybook/node-logger": "^6.5.16",
     "@storybook/preview-web": "^6.5.16",
     "@storybook/react": "^6.5.16",
-    "@storybook/react-docgen-typescript-plugin": "^1.0.1",
     "@storybook/testing-react": "^1.3.0",
     "@storybook/theming": "^6.5.16",
     "@testing-library/jest-dom": "^5.16.5",
@@ -1738,8 +1738,8 @@
     "tough-cookie": "^4.1.4",
     "tree-kill": "^1.2.2",
     "ts-morph": "^15.1.0",
-    "tsd": "^0.20.0",
-    "typescript": "4.9.5",
+    "tsd": "^0.31.1",
+    "typescript": "5.1.6",
     "url-loader": "^2.2.0",
     "val-loader": "^1.1.1",
     "vinyl-fs": "^4.0.0",

packages/core/http/core-http-router-server-internal/src/versioned_router/core_versioned_route.ts

@@ -93,6 +93,7 @@ export class CoreVersionedRoute implements VersionedRoute {
       {
         path: this.path,
         validate: passThroughValidation,
+        // @ts-expect-error upgrade typescript v5.1.6
         options: this.getRouteConfigOptions(),
       },
       this.requestHandler,

packages/core/notifications/core-notifications-browser-internal/src/toasts/global_toast_list.tsx

@@ -30,6 +30,7 @@ interface State {
 
 const convertToEui = (toast: ToastWithRichTitle): EuiToast => ({
   ...toast,
+  // @ts-expect-error upgrade typescript v5.1.6
   title: toast.title instanceof Function ? <MountWrapper mount={toast.title} /> : toast.title,
   text: toast.text instanceof Function ? <MountWrapper mount={toast.text} /> : toast.text,
 });

packages/kbn-alerts-ui-shared/src/rule_form/rule_definition/rule_consumer_selection.tsx

@@ -34,7 +34,6 @@ type ComboBoxOption = EuiComboBoxOptionOption<RuleCreationValidConsumer>;
 
 export const RuleConsumerSelection = (props: RuleConsumerSelectionProps) => {
   const { validConsumers } = props;
-
   const { multiConsumerSelection, baseErrors } = useRuleFormState();
 
   const dispatch = useRuleFormDispatch();

packages/kbn-es-query/src/es_query/from_filters.ts

@@ -36,6 +36,7 @@ const filterNegate = (reverse: boolean) => (filter: Filter) => {
  * @return {Object} the query version of that filter
  */
 const translateToQuery = (filter: Partial<Filter>): estypes.QueryDslQueryContainer => {
+  // @ts-expect-error upgrade typescript v5.1.6
   return filter.query || filter;
 };
 

packages/kbn-eslint-plugin-i18n/rules/formatted_message_should_start_with_the_right_id.ts

@@ -45,6 +45,7 @@ export const FormattedMessageShouldStartWithTheRightId: Rule.RuleModule = {
           idAttribute.value.value;
 
         const i18nAppId = getI18nIdentifierFromFilePath(filename, cwd);
+        // @ts-expect-error upgrade typescript v5.1.6
         const functionDeclaration = sourceCode.getScope(node as TSNode)
           .block as TSESTree.FunctionDeclaration;
         const functionName = getFunctionName(functionDeclaration);

packages/kbn-eslint-plugin-i18n/rules/i18n_translate_should_start_with_the_right_id.ts

@@ -47,6 +47,7 @@ export const I18nTranslateShouldStartWithTheRightId: Rule.RuleModule = {
           node.arguments[0].value;
 
         const i18nAppId = getI18nIdentifierFromFilePath(filename, cwd);
+        // @ts-expect-error upgrade typescript v5.1.6
         const functionDeclaration = sourceCode.getScope(node as TSNode)
           .block as TSESTree.FunctionDeclaration;
         const functionName = getFunctionName(functionDeclaration);

packages/kbn-eslint-plugin-i18n/rules/strings_should_be_translated_with_formatted_message.ts

@@ -40,6 +40,7 @@ export const StringsShouldBeTranslatedWithFormattedMessage: Rule.RuleModule = {
         if (intent === false) return;
 
         const i18nAppId = getI18nIdentifierFromFilePath(filename, cwd);
+        // @ts-expect-error upgrade typescript v5.1.6
         const functionDeclaration = sourceCode.getScope(node as TSNode)
           .block as TSESTree.FunctionDeclaration;
         const functionName = getFunctionName(functionDeclaration);
@@ -107,6 +108,7 @@ export const StringsShouldBeTranslatedWithFormattedMessage: Rule.RuleModule = {
         if (intent === false) return;
 
         const i18nAppId = getI18nIdentifierFromFilePath(filename, cwd);
+        // @ts-expect-error upgrade typescript v5.1.6
         const functionDeclaration = sourceCode.getScope(node as TSNode)
           .block as TSESTree.FunctionDeclaration;
         const functionName = getFunctionName(functionDeclaration);

packages/kbn-eslint-plugin-i18n/rules/strings_should_be_translated_with_i18n.ts

@@ -41,6 +41,7 @@ export const StringsShouldBeTranslatedWithI18n: Rule.RuleModule = {
         if (intent === false) return;
 
         const i18nAppId = getI18nIdentifierFromFilePath(filename, cwd);
+        // @ts-expect-error upgrade typescript v5.1.6
         const functionDeclaration = sourceCode.getScope(node as TSNode)
           .block as TSESTree.FunctionDeclaration;
         const functionName = getFunctionName(functionDeclaration);
@@ -105,6 +106,7 @@ export const StringsShouldBeTranslatedWithI18n: Rule.RuleModule = {
         if (intent === false) return;
 
         const i18nAppId = getI18nIdentifierFromFilePath(filename, cwd);
+        // @ts-expect-error upgrade typescript v5.1.6
         const functionDeclaration = sourceCode.getScope(node as TSNode)
           .block as TSESTree.FunctionDeclaration;
         const functionName = getFunctionName(functionDeclaration);

packages/kbn-eslint-plugin-telemetry/rules/event_generating_elements_should_be_instrumented.ts

@@ -53,6 +53,7 @@ export const EventGeneratingElementsShouldBeInstrumented: Rule.RuleModule = {
         }
 
         const hasDataTestSubjProp = checkNodeForExistingDataTestSubjProp(parent, () =>
+          // @ts-expect-error upgrade typescript v5.1.6
           sourceCode.getScope(node as TSNode)
         );
 
@@ -69,6 +70,7 @@ export const EventGeneratingElementsShouldBeInstrumented: Rule.RuleModule = {
         const appName = getAppName(fileName, cwd);
 
         // 2. Component name
+        // @ts-expect-error upgrade typescript v5.1.6
         const functionDeclaration = sourceCode.getScope(node as TSNode)
           .block as TSESTree.FunctionDeclaration;
         const functionName = getFunctionName(functionDeclaration);

packages/kbn-esql-validation-autocomplete/src/definitions/functions.ts

@@ -1361,7 +1361,7 @@ const logDefinition: FunctionDefinition = {
     // do not really care here about the base and field
     // just need to check both values are not negative
     for (const arg of fnDef.args) {
-      if (isLiteralItem(arg) && arg.value < 0) {
+      if (isLiteralItem(arg) && Number(arg.value) < 0) {
         messages.push({
           type: 'warning' as const,
           code: 'logOfNegativeValue',
@@ -1414,7 +1414,7 @@ const log10Definition: FunctionDefinition = {
     // do not really care here about the base and field
     // just need to check both values are not negative
     for (const arg of fnDef.args) {
-      if (isLiteralItem(arg) && arg.value < 0) {
+      if (isLiteralItem(arg) && Number(arg.value) < 0) {
         messages.push({
           type: 'warning' as const,
           code: 'logOfNegativeValue',

packages/kbn-management/settings/components/field_row/description/description.tsx

@@ -58,6 +58,7 @@ export const FieldDescription = <T extends SettingType>({
          * Justification for dangerouslySetInnerHTML:
          * Setting description may contain formatting and links to documentation.
          */
+        /* @ts-expect-error upgrade typescript v5.1.6 */
         dangerouslySetInnerHTML={{ __html: content || '' }} // eslint-disable-line react/no-danger
       />
     );

packages/kbn-repo-linter/lib/lint_target.ts

@@ -56,11 +56,11 @@ export abstract class LintTarget {
     return this instanceof TsProjectLintTarget;
   }
 
-  getTsProject() {
+  getTsProject(): any {
     return this.isPackage() || this.isTsProject() ? this.tsProject : undefined;
   }
 
-  getPkg() {
+  getPkg(): any {
     return this.isPackage() ? this.pkg : undefined;
   }
 }

packages/kbn-telemetry-tools/src/tools/ts_program/ts_program.test.ts

@@ -21,7 +21,7 @@ describe('createKibanaProgram', () => {
             "fetch": Object {
               "typeDescriptor": Object {
                 "locale": Object {
-                  "kind": 152,
+                  "kind": 154,
                   "type": "StringKeyword",
                 },
               },

packages/kbn-telemetry-tools/src/tools/utils.ts

@@ -145,8 +145,16 @@ export function getResolvedModuleSourceFile(
   originalSource: ts.SourceFile,
   program: ts.Program,
   importedModuleName: string
-) {
-  const resolvedModule = (originalSource as any).resolvedModules.get(importedModuleName);
+): ts.SourceFile {
+  // Resolve the module name to get the resolved module name result
+  const resolvedModuleNameResult = ts.resolveModuleName(
+    importedModuleName,
+    originalSource.fileName,
+    program.getCompilerOptions(),
+    ts.sys
+  );
+
+  const resolvedModule = resolvedModuleNameResult.resolvedModule;
   if (!resolvedModule) {
     throw new Error(
       `Import for [${importedModuleName}] in [${originalSource.fileName}] could not be resolved by TypeScript`

packages/kbn-user-profile-components/src/user_profiles_selectable.tsx

@@ -264,8 +264,8 @@ export const UserProfilesSelectable = <Option extends UserProfileWithAvatar | nu
   return (
     <EuiSelectable
       data-test-subj={props['data-test-subj']}
+      // @ts-expect-error upgrade typescript v5.1.6
       options={displayedOptions}
-      // @ts-expect-error: Type of `nextOptions` in EuiSelectable does not match what's actually being passed back so need to manually override it
       onChange={(
         nextOptions: Array<EuiSelectableOption<{ data: Partial<UserProfileWithAvatar> }>>
       ) => {
@@ -331,26 +331,33 @@ export const UserProfilesSelectable = <Option extends UserProfileWithAvatar | nu
       emptyMessage={emptyMessage}
       errorMessage={errorMessage}
       renderOption={(option, searchValue) => {
+        // @ts-expect-error upgrade typescript v5.1.6
         if (option.user) {
+          // @ts-expect-error upgrade typescript v5.1.6
           const displayName = getUserDisplayName(option.user);
           return (
             <>
               <div className="eui-textTruncate">
                 <EuiHighlight search={searchValue}>{displayName}</EuiHighlight>
               </div>
-              {option.user.email && option.user.email !== displayName ? (
-                <EuiText
-                  size={'xs'}
-                  color={option.disabled ? 'disabled' : 'subdued'}
-                  className="eui-textTruncate"
-                >
-                  {searchValue ? (
-                    <EuiHighlight search={searchValue}>{option.user.email}</EuiHighlight>
-                  ) : (
-                    option.user.email
-                  )}
-                </EuiText>
-              ) : undefined}
+              {
+                /* @ts-expect-error upgrade typescript v5.1.6 */
+                option.user.email && option.user.email !== displayName ? (
+                  <EuiText
+                    size={'xs'}
+                    color={option.disabled ? 'disabled' : 'subdued'}
+                    className="eui-textTruncate"
+                  >
+                    {searchValue ? (
+                      /* @ts-expect-error upgrade typescript v5.1.6 */
+                      <EuiHighlight search={searchValue}>{option.user.email}</EuiHighlight>
+                    ) : (
+                      /* @ts-expect-error upgrade typescript v5.1.6 */
+                      option.user.email
+                    )}
+                  </EuiText>
+                ) : undefined
+              }
             </>
           );
         }

src/plugins/bfetch/public/test_helpers/xhr.ts

@@ -13,10 +13,15 @@ export const mockXMLHttpRequest = (): {
   XMLHttpRequest: typeof window.XMLHttpRequest;
 } => {
   class MockXMLHttpRequest implements XMLHttpRequest {
+    // @ts-expect-error upgrade typescript v5.1.6
     DONE = 0;
+    // @ts-expect-error upgrade typescript v5.1.6
     HEADERS_RECEIVED = 0;
+    // @ts-expect-error upgrade typescript v5.1.6
     LOADING = 0;
+    // @ts-expect-error upgrade typescript v5.1.6
     OPENED = 0;
+    // @ts-expect-error upgrade typescript v5.1.6
     UNSENT = 0;
     abort = jest.fn();
     addEventListener = jest.fn();
@@ -52,6 +57,7 @@ export const mockXMLHttpRequest = (): {
   const xhr = new MockXMLHttpRequest();
 
   return {
+    // @ts-expect-error upgrade typescript v5.1.6
     xhr,
     XMLHttpRequest: class {
       constructor() {

src/plugins/chart_expressions/expression_partition_vis/public/__stories__/shared/config.ts

@@ -59,7 +59,7 @@ export const config: PartitionChartProps['visConfig'] = {
 export const pieConfig: PartitionVisParams = {
   ...config,
   isDonut: false,
-  emptySizeRatio: 0,
+  emptySizeRatio: 0.3,
   distinctColors: false,
   nestedLegend: false,
   dimensions: {

src/plugins/data/common/search/tabify/tabify.test.ts

@@ -13,6 +13,7 @@ import { mockAggTypesRegistry } from '../aggs/test_helpers';
 import { metricOnly, threeTermBuckets } from './fixtures/fake_hierarchical_data';
 import { isSamplingEnabled } from '../aggs/utils/sampler';
 import { timeOffsetFiltersWithZeroDocCountResponse } from './fixtures/fake_timeoffset_data';
+import assert from 'node:assert';
 
 describe('tabifyAggResponse Integration', () => {
   const typesRegistry = mockAggTypesRegistry();
@@ -188,9 +189,9 @@ describe('tabifyAggResponse Integration', () => {
       ) {
         expect(typeof row).toBe('object');
 
-        asserts.forEach((assert, i: number) => {
+        asserts.forEach((a, i: number) => {
           if (row[`col-${i}`]) {
-            assert(row[`col-${i}`]);
+            a(row[`col-${i}`]);
           }
         });
       }
@@ -214,6 +215,7 @@ describe('tabifyAggResponse Integration', () => {
       // check for something like an average bytes result
       function expectAvgBytes(val: string | number) {
         expect(typeof val).toBe('number');
+        assert(typeof val === 'number');
         expect(val === 0 || val > 1000).toBeDefined();
       }