Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OAS] Add operationId values for APM APIs #186840

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 24, 2024

Summary

Per https://spec.openapis.org/oas/v3.0.3#operation-object, operation IDs are optional, but they're used to generate the unique URL for each operation in Bump.sh. Without them, we get URLs that seem to be derived from the API path and contain a mix of dashes and underscores, e.g. "https://www.elastic.co/docs/api/doc/serverless/operation/operation-post-api-apm-agent_keys". With operation IDs the URL will look like this: ".../operation/operation-createagentkey"

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:OAS Work or issues related to Core-provided mechanisms for generating OAS labels Jun 24, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review June 24, 2024 20:21
@lcawl lcawl requested a review from a team as a code owner June 24, 2024 20:21
@lcawl lcawl added the docs label Jun 24, 2024
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jun 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@lcawl lcawl enabled auto-merge (squash) June 24, 2024 21:55
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 24, 2024

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit bb6be5c into elastic:main Jun 24, 2024
21 checks passed
@lcawl lcawl deleted the apm-operationIds branch October 4, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project docs Feature:OAS Work or issues related to Core-provided mechanisms for generating OAS release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants