[Security Solution] [Timelines] Notes table links #187868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqualters-elastic
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
PhilippeOberti
approved these changes
Jul 10, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 10, 2024
## Summary This pr changes the timeline id cell to be a link to open the saved timeline a note is a part of if timelineId exists, instead of just showing the id as a plain string. Also updates the event column to a link that opens a new timeline containing just the event a note is associated with.  ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) (cherry picked from commit 209b0c5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 10, 2024
…187986) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution] [Timelines] Notes table links (#187868)](#187868) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Qualters","email":"56408403+kqualters-elastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-07-10T13:55:02Z","message":"[Security Solution] [Timelines] Notes table links (#187868)\n\n## Summary\r\n\r\nThis pr changes the timeline id cell to be a link to open the saved\r\ntimeline a note is a part of if timelineId exists, instead of just\r\nshowing the id as a plain string. Also updates the event column to a\r\nlink that opens a new timeline containing just the event a note is\r\nassociated with.\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))","sha":"209b0c52cb905cc0b62db9ef9f425d1119cdc549","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","v8.15.0","v8.16.0"],"title":"[Security Solution] [Timelines] Notes table links","number":187868,"url":"https://github.com/elastic/kibana/pull/187868","mergeCommit":{"message":"[Security Solution] [Timelines] Notes table links (#187868)\n\n## Summary\r\n\r\nThis pr changes the timeline id cell to be a link to open the saved\r\ntimeline a note is a part of if timelineId exists, instead of just\r\nshowing the id as a plain string. Also updates the event column to a\r\nlink that opens a new timeline containing just the event a note is\r\nassociated with.\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))","sha":"209b0c52cb905cc0b62db9ef9f425d1119cdc549"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187868","number":187868,"mergeCommit":{"message":"[Security Solution] [Timelines] Notes table links (#187868)\n\n## Summary\r\n\r\nThis pr changes the timeline id cell to be a link to open the saved\r\ntimeline a note is a part of if timelineId exists, instead of just\r\nshowing the id as a plain string. Also updates the event column to a\r\nlink that opens a new timeline containing just the event a note is\r\nassociated with.\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))","sha":"209b0c52cb905cc0b62db9ef9f425d1119cdc549"}}]}] BACKPORT--> Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr changes the timeline id cell to be a link to open the saved timeline a note is a part of if timelineId exists, instead of just showing the id as a plain string. Also updates the event column to a link that opens a new timeline containing just the event a note is associated with.
Checklist
Delete any items that are not applicable to this PR.