[ResponseOps][Rules] Version update api key rule route #188722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
cc @adcoelho |
cnasikas
approved these changes
Jul 22, 2024
JiaweiWu
reviewed
Jul 22, 2024
| @@ -164,7 +164,7 @@ export class RulesClient { | |||
| public bulkDisableRules = (options: BulkDisableRulesRequestBody) => | |||
| bulkDisableRules(this.context, options); | |||
|
|
|||
| public updateApiKey = (options: { id: string }) => updateApiKey(this.context, options); | |||
| public updateApiKey = (params: { id: string }) => updateApiKey(this.context, params); | |||
There was a problem hiding this comment.
let's rename this to updateRuleApiKey so update_api_key.ts -> update_rule_api_key.ts
| } from '../../../../../common/routes/rule/apis/update_api_key'; | ||
| import { ILicenseState, RuleTypeDisabledError } from '../../../../lib'; | ||
| import { verifyAccessAndContext } from '../../../lib'; | ||
| import { AlertingRequestHandlerContext, BASE_ALERTING_API_PATH } from '../../../../types'; | ||
|
|
||
| export const updateRuleApiKeyRoute = ( |
There was a problem hiding this comment.
Let's rename this file update_rule_api_key_route.ts
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: cc @adcoelho |
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parent Issue: #187572
Versions the
POST /rule/{id}/_update_api_keyendpoint.Checklist