[ResponseOps][Rules] Version unmute alert route

[umbopepato]

Summary

Versions the POST /api/alerting/rule/{rule_id}/alert/{alert_id}/_unmute enpoint.

References

Parent issue: #187572
Closes #187574

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[umbopepato]

/ci

[elasticmachine]

Pinging @elastic/response-ops (Team:ResponseOps)

[umbopepato]

/ci

[cnasikas]

LGTM! I will the final approval to @JiaweiWu.

[adcoelho]

Could you please rename
x-pack/plugins/alerting/server/routes/rule/apis/unmute_alert/unmute_alert.ts
and
x-pack/plugins/alerting/server/routes/rule/apis/unmute_alert/unmute_alert.test.ts
to unmute_alert_route.ts and unmute_alert_route.test.ts for consistency?

And a small nit, you can also add #187574 in the description, this PR will close both issues I think.

[adcoelho]

Should this be <UnmuteAlertParamsV1> ?

[umbopepato]

Ah good point. I followed the same structure of the mute_alert endpoint, where that type is not versioned. It seems like none of the types in alerting/server/application/rule/methods is versioned (guess it makes sense since they're used as parameter types of the rules client methods, which have no multiple coexisting versions? 🤔)

[cnasikas]

The rule methods are not versioned intentionally. The transformation functions are versioned. The reason is that they transform a versioned request to a non-versioned method (application) schema. So we transform from UnmuteAlertRequestParamsV1 (from routes/rule/apis/unmute_alert/index.ts) -> UnmuteAlertParams (from application/rule/methods/unmute_alert/types). I would suggest to be more explicit for the types of the params like

export const transformRequestParamsToApplication: RewriteRequestCase<UnmuteAlertParams> = ({rule_id: alertId,
  alert_id: alertInstanceId,
}: UnmuteAlertRequestParamsV1) => ({
  alertId,
  alertInstanceId,
});

Wdyt?

[umbopepato]

Could you please rename x-pack/plugins/alerting/server/routes/rule/apis/unmute_alert/unmute_alert.ts and x-pack/plugins/alerting/server/routes/rule/apis/unmute_alert/unmute_alert.test.ts to unmute_alert_route.ts and unmute_alert_route.test.ts for consistency?

And a small nit, you can also add #187574 in the description, this PR will close both issues I think.

Good catch, thanks! 👍

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: d9aa442

Failed CI Steps

• Jest Tests #3
• FTR Configs #5
• FTR Configs #72
• FTR Configs #88

Test Failures

• [job] [logs] Jest Tests #3 / ColumnsPopover renders correctly a list of selected columns

Metrics [docs]

✅ unchanged

History

• 💛 Build #224389 was flaky 9c2ee868296deca2e6e37ef14409574b8c466d5d
• 💛 Build #224287 was flaky f9ca6d5c2fc6b5cb14853d449481ca2a6ddbd796
• 💛 Build #222912 was flaky 552505c83f89fdd90c869e9599e37d55a16b7a0e
• 💛 Build #222875 was flaky 5150716c256febbc57ce6354d3893ed090272a6f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream