Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Extend the /upgrade/_perform API endpoint's contract migrating to Zod #189790

Merged
merged 8 commits into from
Aug 5, 2024

Conversation

jpdjere
Copy link
Contributor

@jpdjere jpdjere commented Aug 2, 2024

Partially addresses (contract change only): #166376

Created in favour of: #189187 (closed)

Summary

  • Extends contract as described in the POC, migrating from io-ts to Zod (search for Perform rule upgrade)
  • Uses new types in endpoint, but functionality remains unchaged.

For maintainers

@jpdjere jpdjere changed the title Create schema [Security Solution] Extend the /upgrade/_perform API endpoint's contract migrating to Zod Aug 2, 2024
@jpdjere jpdjere marked this pull request as ready for review August 2, 2024 12:17
@jpdjere jpdjere requested a review from a team as a code owner August 2, 2024 12:17
@jpdjere jpdjere requested a review from xcrzx August 2, 2024 12:17
@jpdjere jpdjere self-assigned this Aug 2, 2024
@jpdjere jpdjere added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area v8.16.0 labels Aug 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

targetRules.push(target);
break;
case PickVersionValuesEnum.MERGED:
// TODO: Implement functionality to handle MERGED
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an internal endpoint, and we don't use MERGED yet, this should be safe. Defaulting to updating to TARGET anyways, until actual endpoint implementation is finished.

@jpdjere jpdjere requested a review from xcrzx August 5, 2024 12:10
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5613 5614 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.5MB 20.5MB +6.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jpdjere

Copy link
Contributor

@xcrzx xcrzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you, @jpdjere, for migrating the legacy schemas to Zod, they look much nicer now!

@jpdjere jpdjere merged commit 8d550b0 into elastic:main Aug 5, 2024
42 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants