docs: updates notifications README #189930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
release_note:skip
TinaHeiligers
commented
Aug 5, 2024
| @@ -18,10 +18,10 @@ The `start` function exposes the following interface: | |||
|
|
|||
| To use the exposed plugin start contract: | |||
|
|
|||
| 1. Make sure `notifications` is in your `optionalPlugins` in the `kibana.json` file: | |||
| 1. Make sure `notifications` is in your `requiredPlugins` in the `kibana.jsonc` file: | |||
There was a problem hiding this comment.
Super tiny change: Notifications have to be listed as a required plugin
TinaHeiligers
commented
Aug 5, 2024
|
|
||
| ```json5 | ||
| // <plugin>/kibana.json | ||
| // <plugin>/kibana.jsonc |
There was a problem hiding this comment.
Plugin manifest uses .jsonc
|
Pinging @elastic/kibana-core (Team:Core) |
afharo
changed the title
afharo
approved these changes
Aug 5, 2024
TinaHeiligers
force-pushed
the
update-readme
branch
from
36d0a2d to
bea2263
Compare
Dosant
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications must be a required plugin to send emails