Make mget task claim strategy poll more frequently #190059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Feature:Task Manager
Team:ResponseOps
48 tasks
|
/ci |
|
@elasticmachine merge upstream |
|
/ci |
…/kibana into task-manager/mget-poll-interval
|
/ci |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6710[❌] x-pack/test/task_manager_claimer_mget/config.ts: 0/100 tests passed. |
|
@elasticmachine merge upstream |
|
/ci |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6720[❌] x-pack/test/task_manager_claimer_mget/config.ts: 47/100 tests passed. |
|
/ci |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6722[✅] x-pack/test/task_manager_claimer_mget/config.ts: 100/100 tests passed. |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @mikecote |
mikecote
added
release_note:skip
ersin-erdal
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm changing the default
poll_intervalto500whenever mget claim strategy is set. This keeps the3000value for the default task claiming strategy and settingxpack.task_manager.poll_intervalstill takes precedence.I'm increasing the frequency because we no longer get as much contention when adding Kibana nodes, allowing tasks to be picked up more frequently / on-time.
To verify
3000is the poll intervalxpack.task_manager.claim_strategy: 'unsafe_mget'in the kibana.yml file and wait for Kibana restart500is the poll intervalxpack.task_manager.poll_interval: 3001and wait for Kibana restart3001is the poll intervalxpack.task_manager.claim_strategysetting and wait for Kibana restart3001is still poll intervalxpack.task_manager.poll_intervalsettingFlaky test runner for mget tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6722