Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spaces] Create Space: show features picker only when solution not "classic" #191528

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[Spaces] Create Space: show features picker only when solution not "classic" #191528

merged 1 commit into from
Aug 28, 2024

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Aug 27, 2024 •
edited
Loading

Summary

Users may only choose visible features of a Space when their solution view is set to "classic" (or empty).

Checklist

Delete any items that are not applicable to this PR.

@tsullivan tsullivan added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Aug 27, 2024
@tsullivan tsullivan force-pushed the spaces-ux/create-screen-show-hide-feature-visibility branch 2 times, most recently from 64c0ace to 3169480 Compare August 27, 2024 18:12
@tsullivan tsullivan force-pushed the spaces-ux/create-screen-show-hide-feature-visibility branch from 3169480 to c4e8d32 Compare August 27, 2024 18:22
@tsullivan tsullivan marked this pull request as ready for review August 27, 2024 18:23
@tsullivan tsullivan requested a review from a team as a code owner August 27, 2024 18:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan tsullivan requested a review from sebelga August 27, 2024 18:24
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
spaces 184.2KB 184.5KB +278.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sebelga
sebelga approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tsullivan ! Tested locally and works as expected 👍

@tsullivan tsullivan merged commit 47f74eb into elastic:main Aug 28, 2024
20 checks passed
@tsullivan tsullivan deleted the spaces-ux/create-screen-show-hide-feature-visibility branch August 28, 2024 15:07
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

@SiddharthMantri SiddharthMantri SiddharthMantri approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tsullivan @elasticmachine @kibana-ci @SiddharthMantri @sebelga @kibanamachine