Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Use execFile for quick-checks #191638

Merged
merged 2 commits into from
Aug 30, 2024
Merged

[CI] Use execFile for quick-checks #191638

merged 2 commits into from
Aug 30, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Aug 28, 2024 •
edited by kibanamachine
Loading

Summary

As per the suggestion for https://github.com/elastic/kibana/security/code-scanning/448 - using a safer script execution

@delanni
Copy link
Contributor Author

delanni commented Aug 28, 2024

/ci

1 similar comment
@delanni
Copy link
Contributor Author

delanni commented Aug 28, 2024

/ci

@delanni delanni marked this pull request as ready for review August 29, 2024 08:11
@delanni delanni requested a review from a team as a code owner August 29, 2024 08:11
@delanni delanni marked this pull request as draft August 29, 2024 08:11
@delanni delanni marked this pull request as ready for review August 29, 2024 08:17
@delanni delanni marked this pull request as draft August 29, 2024 08:17
@delanni delanni added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Aug 29, 2024
@delanni delanni marked this pull request as ready for review August 29, 2024 09:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni merged commit 1805b5c into elastic:main Aug 30, 2024
20 checks passed
@delanni delanni removed the backport:skip This commit does not require backporting label Sep 3, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 3, 2024
@delanni delanni added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Sep 3, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 3, 2024
@delanni
[CI] Use execFile for quick-checks (elastic#191638)
c1c1279 
## Summary
As per the suggestion for
https://github.com/elastic/kibana/security/code-scanning/448 - using a
safer script execution

(cherry picked from commit 1805b5c)
@kibanamachine kibanamachine mentioned this pull request Sep 3, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 3, 2024
@kibanamachine @delanni
[8.15] [CI] Use `execFile` for quick-checks (#191638) (#191963
ac78849 
)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[CI] Use `execFile` for quick-checks
(#191638)](#191638)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2024-08-30T08:03:09Z","message":"[CI]
Use `execFile` for quick-checks (#191638)\n\n## Summary\r\nAs per the
suggestion
for\r\nhttps://github.com/elastic/kibana/security/code-scanning/448 -
using a\r\nsafer script
execution","sha":"1805b5cdd11d01c0be1f6a1449c3f92335c2fec9","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:prev-minor","v8.16.0"],"title":"[CI]
Use `execFile` for
quick-checks","number":191638,"url":"https://github.com/elastic/kibana/pull/191638","mergeCommit":{"message":"[CI]
Use `execFile` for quick-checks (#191638)\n\n## Summary\r\nAs per the
suggestion
for\r\nhttps://github.com/elastic/kibana/security/code-scanning/448 -
using a\r\nsafer script
execution","sha":"1805b5cdd11d01c0be1f6a1449c3f92335c2fec9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191638","number":191638,"mergeCommit":{"message":"[CI]
Use `execFile` for quick-checks (#191638)\n\n## Summary\r\nAs per the
suggestion
for\r\nhttps://github.com/elastic/kibana/security/code-scanning/448 -
using a\r\nsafer script
execution","sha":"1805b5cdd11d01c0be1f6a1449c3f92335c2fec9"}}]}]
BACKPORT-->

Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.15.1 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@delanni @elasticmachine @kibana-ci @kibanamachine @jbudz