Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Improving empty object creation in ML packages #191901

Merged
merged 3 commits into from
Sep 3, 2024
Merged

[ML] Improving empty object creation in ML packages #191901

merged 3 commits into from
Sep 3, 2024

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Sep 2, 2024 •
edited by kibanamachine
Loading

Replacing instances of empty object creation with Object.create(null) to remove any risk of prototype pollution.
Related to #191518

@jgowdyelastic jgowdyelastic self-assigned this Sep 2, 2024
@jgowdyelastic jgowdyelastic marked this pull request as ready for review September 2, 2024 10:12
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner September 2, 2024 10:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 547.4KB 547.4KB +1.0B
dataVisualizer 725.0KB 725.0KB +17.0B
indexManagement 679.7KB 679.7KB -11.0B
ml 4.6MB 4.6MB +17.0B
transform 548.6KB 548.6KB +57.0B
uptime 468.0KB 468.0KB -11.0B
total +70.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer 24.5KB 24.5KB +23.0B
fileUpload 14.8KB 14.8KB -11.0B
ml 78.7KB 78.8KB +23.0B
total +35.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

walterra
walterra approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jgowdyelastic jgowdyelastic merged commit e204184 into elastic:main Sep 3, 2024
20 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 191901

Questions ?

Please refer to the Backport tool documentation

jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Sep 3, 2024
@jgowdyelastic
[8.15] [ML] Improving empty object creation in ML packages (elastic#1…
2a50a91 
…91901)
@jgowdyelastic jgowdyelastic mentioned this pull request Sep 3, 2024
Merged
@kibanamachine kibanamachine mentioned this pull request Sep 3, 2024
Merged
jgowdyelastic added a commit that referenced this pull request Sep 4, 2024
@jgowdyelastic
[8.15] [ML] Improving empty object creation in ML packages (#191901) (#…
684bf40 
…191991)

Manual backport of #191901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
:ml release_note:fix v8.15.1 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @walterra @peteharverson