Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Enable cursor sync for timeseries charts #192837

Merged
merged 7 commits into from
Sep 16, 2024
Merged

[ES|QL] Enable cursor sync for timeseries charts #192837

merged 7 commits into from
Sep 16, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Sep 13, 2024 •
edited by kibanamachine
Loading

Summary

Syncs the cursor for timeseries charts powered by ES|QL

meow

Checklist

@stratoula stratoula changed the title [ES|QL] Enable cursor sync for charts with date columns [ES|QL] Enable cursor sync for timeseries charts Sep 13, 2024
@stratoula stratoula added release_note:enhancement v8.16.0 Feature:Lens Feature:ES|QL ES|QL related features in Kibana Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 13, 2024
@stratoula stratoula marked this pull request as ready for review September 13, 2024 15:49
@stratoula stratoula requested a review from a team as a code owner September 13, 2024 15:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula stratoula requested a review from markov00 September 13, 2024 15:49
@stratoula stratoula added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v9.0.0 labels Sep 13, 2024
@stratoula
Copy link
Contributor Author

/ci

stratoula and others added 2 commits September 16, 2024 09:57
@stratoula @markov00
Update src/plugins/charts/public/services/active_cursor/active_cursor…
64ebaf0 
…_utils.ts

Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
@stratoula @markov00
Update src/plugins/charts/public/services/active_cursor/active_cursor…
e40a840 
…_utils.test.ts

Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
charts 44.9KB 45.3KB +352.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit a581087 into elastic:main Sep 16, 2024
29 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 16, 2024
@stratoula
[ES|QL] Enable cursor sync for timeseries charts (elastic#192837)
7ef4897 
## Summary

Syncs the cursor for timeseries charts powered by ES|QL

![meow](https://github.com/user-attachments/assets/62664b27-ce95-493d-863a-b5ecaa8006ed)

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
(cherry picked from commit a581087)
@kibanamachine kibanamachine mentioned this pull request Sep 16, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 16, 2024
@kibanamachine @stratoula
[8.x] [ES|QL] Enable cursor sync for timeseries charts (#192837) (#19…
8f01c22 
…2982)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Enable cursor sync for timeseries charts
(#192837)](#192837)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-09-16T10:03:58Z","message":"[ES|QL]
Enable cursor sync for timeseries charts (#192837)\n\n##
Summary\r\n\r\nSyncs the cursor for timeseries charts powered by
ES|QL\r\n\r\n\r\n![meow](https://github.com/user-attachments/assets/62664b27-ce95-493d-863a-b5ecaa8006ed)\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Marco Vettorello
<vettorello.marco@gmail.com>","sha":"a581087f530ce4a9143d54d76147b7b645a39da4","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Visualizations","Feature:Lens","v9.0.0","backport:prev-minor","Feature:ES|QL","v8.16.0"],"title":"[ES|QL]
Enable cursor sync for timeseries
charts","number":192837,"url":"https://github.com/elastic/kibana/pull/192837","mergeCommit":{"message":"[ES|QL]
Enable cursor sync for timeseries charts (#192837)\n\n##
Summary\r\n\r\nSyncs the cursor for timeseries charts powered by
ES|QL\r\n\r\n\r\n![meow](https://github.com/user-attachments/assets/62664b27-ce95-493d-863a-b5ecaa8006ed)\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Marco Vettorello
<vettorello.marco@gmail.com>","sha":"a581087f530ce4a9143d54d76147b7b645a39da4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192837","number":192837,"mergeCommit":{"message":"[ES|QL]
Enable cursor sync for timeseries charts (#192837)\n\n##
Summary\r\n\r\nSyncs the cursor for timeseries charts powered by
ES|QL\r\n\r\n\r\n![meow](https://github.com/user-attachments/assets/62664b27-ce95-493d-863a-b5ecaa8006ed)\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Marco Vettorello
<vettorello.marco@gmail.com>","sha":"a581087f530ce4a9143d54d76147b7b645a39da4"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stratoula @elasticmachine @kibana-ci @kibanamachine @markov00