Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Fixes Incomplete string escaping or encoding error #193384

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Sep 19, 2024

Summary

Closes https://github.com/elastic/kibana-team/issues/1087

I think that this change will close the second problem. Not 100% sure but this is how I interpret it

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Sep 19, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 812.5KB 812.5KB +1.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 419.1KB 419.1KB +1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review September 19, 2024 11:14
@stratoula stratoula requested a review from a team as a code owner September 19, 2024 11:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula merged commit 88163b0 into elastic:main Sep 19, 2024
29 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 19, 2024
…93384)

## Summary

Closes elastic/kibana-team#1087

I think that this change will close the second problem. Not 100% sure
but this is how I interpret it

(cherry picked from commit 88163b0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 19, 2024
…3384) (#193432)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Fixes Incomplete string escaping or encoding error
(#193384)](#193384)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-09-19T14:07:44Z","message":"[ES|QL]
Fixes Incomplete string escaping or encoding error (#193384)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana-team/issues/1087\r\n\r\nI think that
this change will close the second problem. Not 100% sure\r\nbut this is
how I interpret
it","sha":"88163b063a79520e1dafc7d9548f040a1323522b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"[ES|QL]
Fixes Incomplete string escaping or encoding
error","number":193384,"url":"https://github.com/elastic/kibana/pull/193384","mergeCommit":{"message":"[ES|QL]
Fixes Incomplete string escaping or encoding error (#193384)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana-team/issues/1087\r\n\r\nI think that
this change will close the second problem. Not 100% sure\r\nbut this is
how I interpret
it","sha":"88163b063a79520e1dafc7d9548f040a1323522b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193384","number":193384,"mergeCommit":{"message":"[ES|QL]
Fixes Incomplete string escaping or encoding error (#193384)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana-team/issues/1087\r\n\r\nI think that
this change will close the second problem. Not 100% sure\r\nbut this is
how I interpret
it","sha":"88163b063a79520e1dafc7d9548f040a1323522b"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants