[Search][Ent Search deprecation] Web Crawler tile points out GH repo instead become disabled

[JoseLuisGJ]

Summary

This PR sets the Web Crawler tile to point out the external Open Web Crawler repo when there is no ent-search node running rather than become disabled using the crawlerDisabled

Before:

After:

Also the empty state of Web crawler points out to the Source code repo when there is no ent-search instance running using the errorConnectingMessage. This improvement should fix this issue https://github.com/elastic/search-team/issues/8319?reload=1?reload=1

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Flaky Test Runner was used on any tests changed
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[JoseLuisGJ]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 4d4c9a2

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
enterpriseSearch	2302	2303	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
enterpriseSearch	2.6MB	2.6MB	+1.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
enterpriseSearch	53.6KB	53.7KB	+87.0B

History

• 💔 Build #238998 failed b7bf13c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @JoseLuisGJ

[efegurkan]

We already have one github icon in assets folder you can use this one.

[efegurkan]

Well it is just a duplication, but looks like we already break a lot of rules previously 😬 It can stay. If you want to try already existing one

This file has the export for the same svg x-pack/plugins/enterprise_search/public/assets/client_libraries/index.ts

[JoseLuisGJ]

It's weird, the Github icon is not exported in the pack/plugins/enterprise_search/public/assets/client_libraries/index.ts file. But semantically makes sense, it's not a language client. Anyway I tried to import directly this SVG and it doesn't get the Fill color value of the button as it does with the one I'm already consuming. For now I think I will use the one I added, but we should review how we should reuse all these assets in a more efficient way.

[efegurkan]

It is a small change so it can stay like this. It is possible to do the differences on prop level like this

<IngestionCard 
    buttonLabel={!crawlerDisabled? 
i18n.translate('xpack....', { defaultMessage: 'Crawl URL' }) : 
i18n.translate('xpack....', { defaultMessage: 'Source code' })
}

Or for the ones that are repeating, extract them into a variable

const CRAWLER_LABEL  = i18n.translate('xpack.enterpriseSearch.ingestSelector.method.crawler', {
                  defaultMessage: 'Web Crawler',
                })

// and use it like 

<IngestionCard
    title={CRAWLER_LABEL} ...

[JoseLuisGJ]

Good tip, it will look like this:

<IngestionCard
              buttonLabel={
                crawlerDisabled
                  ? i18n.translate(
                      'xpack.enterpriseSearch.ingestSelector.method.sourceCodeButtonLabel',
                      {
                        defaultMessage: 'Source code',
                      }
                    )
                  : i18n.translate(
                      'xpack.enterpriseSearch.ingestSelector.method.crawler.description',
                      {
                        defaultMessage:
                          'Discover, extract, and index searchable content from websites and knowledge bases.',
                      }
                    )
              }
              buttonIcon={crawlerDisabled ? GithubIcon : CrawlerIcon}
              description={i18n.translate(
                'xpack.enterpriseSearch.ingestSelector.method.crawler.description',
                {
                  defaultMessage:
                    'Discover, extract, and index searchable content from websites and knowledge bases.',
                }
              )}
              href={
                crawlerDisabled
                  ? CRAWLER.github_repo
                  : generatePath(ENTERPRISE_SEARCH_CONTENT_PLUGIN.URL + NEW_CRAWLER_PATH)
              }
              isBeta={crawlerDisabled}
              logo={crawlerLogo}
              title={i18n.translate('xpack.enterpriseSearch.ingestSelector.method.crawler', {
                defaultMessage: 'Web Crawler',
              })}
            />

[JoseLuisGJ]

@elasticmachine merge upstream

[JoseLuisGJ]

@elasticmachine merge upstream

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 3abc960

Failed CI Steps

• FTR Configs #64

Test Failures

• [job] [logs] FTR Configs #64 / Entity Analytics - Risk Engine @ess @serverless @serverlessQA init_and_status_apis status api should disable / enable risk engine

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
enterpriseSearch	2301	2302	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
enterpriseSearch	2.6MB	2.6MB	+1.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
enterpriseSearch	52.5KB	52.6KB	+87.0B

History

• 💛 Build #241644 was flaky 51dec6a
• 💔 Build #241624 failed 5e409c1
• 💔 Build #240268 failed 1417bda
• 💚 Build #240162 succeeded 793dd87

cc @JoseLuisGJ

[kibanamachine]

Starting backport for target branches: 8.15, 8.x

https://github.com/elastic/kibana/actions/runs/11326814245

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.15
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[mistic]

This PR didn't make it into the latest BC of v8.15.3. Updating the labels.