[Console] Fix double escaping issue from code scan #194938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Feature:Console
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @sabarasaba |
ElenaStoeva
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Thanks for fixing this @sabarasaba! Changes lgtm, tested locally,
|
Starting backport for target branches: 7.17, 8.15, 8.x https://github.com/elastic/kibana/actions/runs/11190894174 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2024
(cherry picked from commit c51f850)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2024
(cherry picked from commit c51f850)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2024
(cherry picked from commit c51f850)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2024
…195164) # Backport This will backport the following commits from `main` to `8.15`: - [[Console] Fix double escaping issue from code scan (#194938)](#194938) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2024-10-05T05:52:18Z","message":"[Console] Fix double escaping issue from code scan (#194938)","sha":"c51f8506aad1e0707591549faaf81ad9af8b42e3","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","backport:all-open"],"title":"[Console] Fix double escaping issue from code scan","number":194938,"url":"https://github.com/elastic/kibana/pull/194938","mergeCommit":{"message":"[Console] Fix double escaping issue from code scan (#194938)","sha":"c51f8506aad1e0707591549faaf81ad9af8b42e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194938","number":194938,"mergeCommit":{"message":"[Console] Fix double escaping issue from code scan (#194938)","sha":"c51f8506aad1e0707591549faaf81ad9af8b42e3"}}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2024
…195165) # Backport This will backport the following commits from `main` to `8.x`: - [[Console] Fix double escaping issue from code scan (#194938)](#194938) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2024-10-05T05:52:18Z","message":"[Console] Fix double escaping issue from code scan (#194938)","sha":"c51f8506aad1e0707591549faaf81ad9af8b42e3","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","backport:all-open"],"title":"[Console] Fix double escaping issue from code scan","number":194938,"url":"https://github.com/elastic/kibana/pull/194938","mergeCommit":{"message":"[Console] Fix double escaping issue from code scan (#194938)","sha":"c51f8506aad1e0707591549faaf81ad9af8b42e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194938","number":194938,"mergeCommit":{"message":"[Console] Fix double escaping issue from code scan (#194938)","sha":"c51f8506aad1e0707591549faaf81ad9af8b42e3"}}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2024
…195163) # Backport This will backport the following commits from `main` to `7.17`: - [[Console] Fix double escaping issue from code scan (#194938)](#194938) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2024-10-05T05:52:18Z","message":"[Console] Fix double escaping issue from code scan (#194938)","sha":"c51f8506aad1e0707591549faaf81ad9af8b42e3","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","backport:all-open"],"title":"[Console] Fix double escaping issue from code scan","number":194938,"url":"https://github.com/elastic/kibana/pull/194938","mergeCommit":{"message":"[Console] Fix double escaping issue from code scan (#194938)","sha":"c51f8506aad1e0707591549faaf81ad9af8b42e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194938","number":194938,"mergeCommit":{"message":"[Console] Fix double escaping issue from code scan (#194938)","sha":"c51f8506aad1e0707591549faaf81ad9af8b42e3"}}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/elastic/kibana/security/code-scanning/53
Summary
To fix the problem, we need to ensure that the unescape function correctly handles the unescaping process without causing double unescaping. The best way to achieve this is to unescape the backslash last, ensuring that any escaped characters are correctly processed before handling the escape character itself.
In order to test this: run
GET /.kibana_ingestin console and make sure that the warning header is shown correctly in the output panel.