Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automatic Import] Add Cypress tests for Automatic Import UI flow #194948

Merged
merged 12 commits into from
Oct 10, 2024
Merged

[Automatic Import] Add Cypress tests for Automatic Import UI flow #194948

merged 12 commits into from
Oct 10, 2024

Conversation

bhapas
Copy link
Contributor

@bhapas bhapas commented Oct 4, 2024 •
edited by kibanamachine
Loading

Summary

Adds Cypress functional UI tests for different flows in Automatic Import.

RBAC tests

Create Integration Landing Page

  • Fleet read Integrations all -- No access
  • Fleet read Integrations read -- No access
  • Fleet read Integrations read -- No access
  • Fleet all Integrations all -- Access

Create Integration Assistant Page

  • Fleet/integrations all Actions read [ show execute ] -- Execute with existing connectors
  • Fleet/integrations all Actions all [ show execute save delete ] -- Create new connector / execute existing ones.

Create Integration UI Flow - NDJSON example

  • Create an integration using Automatic Import with NDJSON samples
video1342234299.mp4

@bhapas bhapas self-assigned this Oct 7, 2024
@bhapas bhapas added Team:Security-Scalability Team label for Security Integrations Scalability Team enhancement New value added to drive a business result 8.16 candidate Feature:AutomaticImport labels Oct 7, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 948.9KB 949.1KB +226.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhapas

@bhapas bhapas marked this pull request as ready for review October 8, 2024 08:40
@bhapas bhapas requested review from a team as code owners October 8, 2024 08:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@bhapas bhapas added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 8, 2024
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@bhapas bhapas force-pushed the automatic_import_cypress_tests branch 2 times, most recently from ad7c028 to de992eb Compare October 8, 2024 15:02
@bhapas bhapas force-pushed the automatic_import_cypress_tests branch from de992eb to 3035c08 Compare October 8, 2024 15:04
@bhapas bhapas force-pushed the automatic_import_cypress_tests branch from d39e4c9 to e2b31eb Compare October 9, 2024 08:56
@bhapas bhapas requested a review from semd October 9, 2024 13:23
nchaulet
nchaulet approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM 🚀

kgeller
kgeller approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

semd
semd approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

x-pack/plugins/integration_assistant/server/templates/build_rdm.md.njk Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 948.9KB 949.2KB +312.0B

History

cc @bhapas

@delanni delanni merged commit c920033 into elastic:main Oct 10, 2024
21 of 22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11271332787

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 194948

Questions ?

Please refer to the Backport tool documentation

@bhapas bhapas mentioned this pull request Oct 10, 2024
Merged
@bhapas
Copy link
Contributor Author

bhapas commented Oct 10, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

bhapas added a commit to bhapas/kibana that referenced this pull request Oct 10, 2024
@bhapas
[Automatic Import] Add Cypress tests for Automatic Import UI flow (el…
8cfa6b9 
…astic#194948)

## Summary

Adds Cypress functional UI tests for different flows in Automatic
Import.

- Relates [elastic#192684](elastic#192684)

### RBAC tests

#### Create Integration Landing Page
- Fleet `read` Integrations `all` -- No access
- Fleet `read` Integrations `read` -- No access
- Fleet `read` Integrations `read` -- No access
- Fleet `all` Integrations `all` -- Access

#### Create Integration Assistant Page
- Fleet/integrations `all` Actions `read` [ `show` `execute` ] --
Execute with existing connectors
- Fleet/integrations `all` Actions `all` [ `show` `execute` `save`
`delete` ] -- Create new connector / execute existing ones.

### Create Integration UI Flow - NDJSON example
- Create an integration using Automatic Import with NDJSON samples

https://github.com/user-attachments/assets/9ab4cfc2-f058-4491-a280-6b86bcc5c9ce

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c920033)

# Conflicts:
#	x-pack/plugins/integration_assistant/server/integration_builder/readme_files.ts
#	x-pack/plugins/integration_assistant/server/templates/build_readme.md.njk
#	x-pack/plugins/integration_assistant/server/templates/description_readme.njk
#	x-pack/plugins/integration_assistant/server/templates/package_readme.md.njk
bhapas added a commit that referenced this pull request Oct 10, 2024
@bhapas
[8.x] [Automatic Import] Add Cypress tests for Automatic Import UI fl…
d9aeca0 
…ow (#194948) (#195737)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Automatic Import] Add Cypress tests for Automatic Import UI flow
(#194948)](#194948)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bharat
Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-10T09:31:30Z","message":"[Automatic
Import] Add Cypress tests for Automatic Import UI flow (#194948)\n\n##
Summary\r\n\r\nAdds Cypress functional UI tests for different flows in
Automatic\r\nImport.\r\n\r\n- Relates
[#192684](https://github.com/elastic/kibana/issues/192684)\r\n\r\n###
RBAC tests\r\n\r\n#### Create Integration Landing Page\r\n- Fleet `read`
Integrations `all` -- No access\r\n- Fleet `read` Integrations `read` --
No access\r\n- Fleet `read` Integrations `read` -- No access\r\n- Fleet
`all` Integrations `all` -- Access\r\n\r\n#### Create Integration
Assistant Page\r\n- Fleet/integrations `all` Actions `read` [ `show`
`execute` ] --\r\nExecute with existing connectors\r\n-
Fleet/integrations `all` Actions `all` [ `show` `execute`
`save`\r\n`delete` ] -- Create new connector / execute existing
ones.\r\n\r\n### Create Integration UI Flow - NDJSON example\r\n- Create
an integration using Automatic Import with NDJSON
samples\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/9ab4cfc2-f058-4491-a280-6b86bcc5c9ce\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"c9200332ffe13e1df7225f023fa493f415ab429f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["enhancement","release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","8.16
candidate","Team:Security-Scalability","Feature:AutomaticImport"],"number":194948,"url":"https://github.com/elastic/kibana/pull/194948","mergeCommit":{"message":"[Automatic
Import] Add Cypress tests for Automatic Import UI flow (#194948)\n\n##
Summary\r\n\r\nAdds Cypress functional UI tests for different flows in
Automatic\r\nImport.\r\n\r\n- Relates
[#192684](https://github.com/elastic/kibana/issues/192684)\r\n\r\n###
RBAC tests\r\n\r\n#### Create Integration Landing Page\r\n- Fleet `read`
Integrations `all` -- No access\r\n- Fleet `read` Integrations `read` --
No access\r\n- Fleet `read` Integrations `read` -- No access\r\n- Fleet
`all` Integrations `all` -- Access\r\n\r\n#### Create Integration
Assistant Page\r\n- Fleet/integrations `all` Actions `read` [ `show`
`execute` ] --\r\nExecute with existing connectors\r\n-
Fleet/integrations `all` Actions `all` [ `show` `execute`
`save`\r\n`delete` ] -- Create new connector / execute existing
ones.\r\n\r\n### Create Integration UI Flow - NDJSON example\r\n- Create
an integration using Automatic Import with NDJSON
samples\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/9ab4cfc2-f058-4491-a280-6b86bcc5c9ce\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"c9200332ffe13e1df7225f023fa493f415ab429f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194948","number":194948,"mergeCommit":{"message":"[Automatic
Import] Add Cypress tests for Automatic Import UI flow (#194948)\n\n##
Summary\r\n\r\nAdds Cypress functional UI tests for different flows in
Automatic\r\nImport.\r\n\r\n- Relates
[#192684](https://github.com/elastic/kibana/issues/192684)\r\n\r\n###
RBAC tests\r\n\r\n#### Create Integration Landing Page\r\n- Fleet `read`
Integrations `all` -- No access\r\n- Fleet `read` Integrations `read` --
No access\r\n- Fleet `read` Integrations `read` -- No access\r\n- Fleet
`all` Integrations `all` -- Access\r\n\r\n#### Create Integration
Assistant Page\r\n- Fleet/integrations `all` Actions `read` [ `show`
`execute` ] --\r\nExecute with existing connectors\r\n-
Fleet/integrations `all` Actions `all` [ `show` `execute`
`save`\r\n`delete` ] -- Create new connector / execute existing
ones.\r\n\r\n### Create Integration UI Flow - NDJSON example\r\n- Create
an integration using Automatic Import with NDJSON
samples\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/9ab4cfc2-f058-4491-a280-6b86bcc5c9ce\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"c9200332ffe13e1df7225f023fa493f415ab429f"}}]}]
BACKPORT-->
@haetamoudi haetamoudi mentioned this pull request Dec 13, 2024
Merged
7 tasks
haetamoudi added a commit that referenced this pull request Dec 13, 2024
@haetamoudi
[8.x] [Automatic Import] delete readme file (#204244)
ca17364 
## Summary

Manually delete `readme.njk` file that was missed during backport
#194948 PR in main
#195737 - 8.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

@kgeller kgeller kgeller approved these changes

@nchaulet nchaulet nchaulet approved these changes

Assignees

@bhapas bhapas

Labels
8.16 candidate backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) enhancement New value added to drive a business result Feature:AutomaticImport release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Security-Scalability Team label for Security Integrations Scalability Team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bhapas @kibana-ci @elasticmachine @kibanamachine @nchaulet @kgeller @semd @delanni