[Inventory] Check permissions before registering the Inventory plugin in observabilityShared navigation #195557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancof
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
…d-in-observability-navigation-without-necessary-permissions
|
Warning
|
…ability-navigation-without-necessary-permissions' of https://github.com/iblancof/kibana into 195360-inventory-plugin-incorrectly-displayed-in-observability-navigation-without-necessary-permissions
iblancof
changed the title
…d-in-observability-navigation-without-necessary-permissions
x-pack/plugins/observability_solution/inventory/public/plugin.ts
Outdated
Show resolved
Hide resolved
…d-in-observability-navigation-without-necessary-permissions
💚 Build Succeeded
Metrics [docs]Page load bundle
History
cc @iblancof |
jloleysens
approved these changes
Oct 10, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11274086035 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
… in observabilityShared navigation (elastic#195557) ## Summary Fixes elastic#195360 and elastic#195560 This PR fixes a bug where the Inventory plugin is improperly registered in the ObservabilityShared navigation, even in spaces that lack the required permissions or for user roles that don't have permissions. As a result, the Inventory link appears in the navigation whenever the space/user has access to any other Observability plugin. ### Space permissions #### Before |Space config|ObservabilityShared navigation| |-|-| ||| ##### After |Space config|ObservabilityShared navigation| |-|-| ||| ||| ### User permissions #### Before |Role config|ObservabilityShared navigation| |-|-| ||| #### After |Role config|ObservabilityShared navigation| |-|-| ||<img width="1266" alt="Screenshot 2024-10-09 at 12 52 48" src="https://github.com/user-attachments/assets/5d21bbef-53ca-4d83-84b7-d471a12a40e3">| (cherry picked from commit 7927ebf)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
iblancof
deleted the
195360-inventory-plugin-incorrectly-displayed-in-observability-navigation-without-necessary-permissions
branch
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2024
…plugin in observabilityShared navigation (#195557) (#195758) # Backport This will backport the following commits from `main` to `8.x`: - [[Inventory] Check permissions before registering the Inventory plugin in observabilityShared navigation (#195557)](#195557) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"irene.blanco@elastic.co"},"sourceCommit":{"committedDate":"2024-10-10T12:32:37Z","message":"[Inventory] Check permissions before registering the Inventory plugin in observabilityShared navigation (#195557)\n\n## Summary\r\n\r\nFixes #195360 and\r\nhttps://github.com//issues/195560\r\n\r\nThis PR fixes a bug where the Inventory plugin is improperly registered\r\nin the ObservabilityShared navigation, even in spaces that lack the\r\nrequired permissions or for user roles that don't have permissions. As a\r\nresult, the Inventory link appears in the navigation whenever the\r\nspace/user has access to any other Observability plugin.\r\n\r\n\r\n### Space permissions\r\n#### Before\r\n|Space config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n|||\r\n\r\n\r\n##### After\r\n|Space config|ObservabilityShared navigation|\r\n|-|-|\r\n|||\r\n|||\r\n\r\n\r\n### User permissions\r\n\r\n#### Before\r\n|Role config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n|||\r\n\r\n\r\n#### After\r\n|Role config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n||<img\r\nwidth=\"1266\" alt=\"Screenshot 2024-10-09 at 12 52 48\"\r\nsrc=\"https://github.com/user-attachments/assets/5d21bbef-53ca-4d83-84b7-d471a12a40e3\">|","sha":"7927ebf2a6e3bc459acb6d3217cb87ba8f837e09","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"title":"[Inventory] Check permissions before registering the Inventory plugin in observabilityShared navigation","number":195557,"url":"https://github.com/elastic/kibana/pull/195557","mergeCommit":{"message":"[Inventory] Check permissions before registering the Inventory plugin in observabilityShared navigation (#195557)\n\n## Summary\r\n\r\nFixes #195360 and\r\nhttps://github.com//issues/195560\r\n\r\nThis PR fixes a bug where the Inventory plugin is improperly registered\r\nin the ObservabilityShared navigation, even in spaces that lack the\r\nrequired permissions or for user roles that don't have permissions. As a\r\nresult, the Inventory link appears in the navigation whenever the\r\nspace/user has access to any other Observability plugin.\r\n\r\n\r\n### Space permissions\r\n#### Before\r\n|Space config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n|||\r\n\r\n\r\n##### After\r\n|Space config|ObservabilityShared navigation|\r\n|-|-|\r\n|||\r\n|||\r\n\r\n\r\n### User permissions\r\n\r\n#### Before\r\n|Role config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n|||\r\n\r\n\r\n#### After\r\n|Role config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n||<img\r\nwidth=\"1266\" alt=\"Screenshot 2024-10-09 at 12 52 48\"\r\nsrc=\"https://github.com/user-attachments/assets/5d21bbef-53ca-4d83-84b7-d471a12a40e3\">|","sha":"7927ebf2a6e3bc459acb6d3217cb87ba8f837e09"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195557","number":195557,"mergeCommit":{"message":"[Inventory] Check permissions before registering the Inventory plugin in observabilityShared navigation (#195557)\n\n## Summary\r\n\r\nFixes #195360 and\r\nhttps://github.com//issues/195560\r\n\r\nThis PR fixes a bug where the Inventory plugin is improperly registered\r\nin the ObservabilityShared navigation, even in spaces that lack the\r\nrequired permissions or for user roles that don't have permissions. As a\r\nresult, the Inventory link appears in the navigation whenever the\r\nspace/user has access to any other Observability plugin.\r\n\r\n\r\n### Space permissions\r\n#### Before\r\n|Space config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n|||\r\n\r\n\r\n##### After\r\n|Space config|ObservabilityShared navigation|\r\n|-|-|\r\n|||\r\n|||\r\n\r\n\r\n### User permissions\r\n\r\n#### Before\r\n|Role config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n|||\r\n\r\n\r\n#### After\r\n|Role config|ObservabilityShared navigation|\r\n|-|-|\r\n\r\n||<img\r\nwidth=\"1266\" alt=\"Screenshot 2024-10-09 at 12 52 48\"\r\nsrc=\"https://github.com/user-attachments/assets/5d21bbef-53ca-4d83-84b7-d471a12a40e3\">|","sha":"7927ebf2a6e3bc459acb6d3217cb87ba8f837e09"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <irene.blanco@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #195360 and #195560
This PR fixes a bug where the Inventory plugin is improperly registered in the ObservabilityShared navigation, even in spaces that lack the required permissions or for user roles that don't have permissions. As a result, the Inventory link appears in the navigation whenever the space/user has access to any other Observability plugin.
Space permissions
Before
After
User permissions
Before
After