Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Extract AI assistant to package (#194552) #196011

Merged
merged 2 commits into from
Oct 12, 2024
Merged

[8.x] Extract AI assistant to package (#194552) #196011

merged 2 commits into from
Oct 12, 2024

Conversation

sphilipse
Copy link
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@sphilipse
Extract AI assistant to package (elastic#194552)
716d545 
## Summary

This extracts the Observability AI Assistant into a shared package so
Search and Observability can both consume it.

A few notes:

This still relies on significantly tight coupling with the Obs AI
assistant plugin, which we will want to slowly decouple over time. It
means that currently to consume this in multiple places, you need to
provide a number of plugins for useKibana. Hopefully we can get rid of
that and replace them with props eventually and make the interface a
little less plugin-dependent.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8a3a059)

# Conflicts:
#	.github/CODEOWNERS
@sphilipse sphilipse enabled auto-merge (squash) October 12, 2024 08:04
@sphilipse sphilipse mentioned this pull request Oct 12, 2024
Merged
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Oct 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 12, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityAIAssistant 105 106 +1
observabilityAIAssistantApp 248 251 +3
searchAssistant 4 172 +168
total +172

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ai-assistant - 62 +62
observabilityAIAssistant 291 292 +1
total +63

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistantApp 154.4KB 153.7KB -676.0B
searchAssistant 0.0B 97.0KB +97.0KB
total +96.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/ai-assistant - 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistant 46.1KB 46.2KB +155.0B
observabilityAIAssistantApp 8.6KB 8.7KB +52.0B
searchAssistant 1.5KB 4.9KB +3.4KB
total +3.6KB
Unknown metric groups

API count

id before after diff
@kbn/ai-assistant - 62 +62
observabilityAIAssistant 293 294 +1
total +63

async chunk count

id before after diff
searchAssistant 0 1 +1

ESLint disabled line counts

id before after diff
@kbn/ai-assistant - 8 +8
observabilityAIAssistantApp 14 10 -4
total +4

miscellaneous assets size

id before after diff
observabilityAIAssistant 0.0B 92.9KB +92.9KB
observabilityAIAssistantApp 92.9KB 0.0B -92.9KB
searchAssistant 0.0B 161.8KB +161.8KB
total +161.8KB

Total ESLint disabled count

id before after diff
@kbn/ai-assistant - 8 +8
observabilityAIAssistantApp 14 10 -4
total +4

History

@sphilipse sphilipse requested a review from dgieselaar October 12, 2024 11:03
@sphilipse sphilipse merged commit 8fef06f into elastic:8.x Oct 12, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sphilipse @elasticmachine @dgieselaar @kibanamachine