Reenable console flaky test font size #197563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
mattkime
added
the
Team:Kibana Management
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7240[✅] test/functional/apps/console/config.ts: 25/25 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7241[✅] test/functional/apps/console/config.ts: 200/200 tests passed. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
## Summary The test no longer appears flaky based on the flaky test runner. In addition to this PR there's also elastic#197563 for 400+ passes. It should be noted that in one run 25 runs were skipped and one run failed due to an unrelated test. Closes elastic#193868 (cherry picked from commit 92430b5)
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[console] Restore font size flaky test (#197691)](#197691) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthew Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2024-10-31T19:30:55Z","message":"[console] Restore font size flaky test (#197691)\n\n## Summary\r\n\r\nThe test no longer appears flaky based on the flaky test runner. In\r\naddition to this PR there's also\r\nhttps://github.com//pull/197563 for 400+ passes. It should\r\nbe noted that in one run 25 runs were skipped and one run failed due to\r\nan unrelated test.\r\n\r\nCloses https://github.com/elastic/kibana/issues/193868","sha":"92430b5aae3911a4278983415cc73aacfb3e924b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[console] Restore font size flaky test","number":197691,"url":"https://github.com/elastic/kibana/pull/197691","mergeCommit":{"message":"[console] Restore font size flaky test (#197691)\n\n## Summary\r\n\r\nThe test no longer appears flaky based on the flaky test runner. In\r\naddition to this PR there's also\r\nhttps://github.com//pull/197563 for 400+ passes. It should\r\nbe noted that in one run 25 runs were skipped and one run failed due to\r\nan unrelated test.\r\n\r\nCloses https://github.com/elastic/kibana/issues/193868","sha":"92430b5aae3911a4278983415cc73aacfb3e924b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197691","number":197691,"mergeCommit":{"message":"[console] Restore font size flaky test (#197691)\n\n## Summary\r\n\r\nThe test no longer appears flaky based on the flaky test runner. In\r\naddition to this PR there's also\r\nhttps://github.com//pull/197563 for 400+ passes. It should\r\nbe noted that in one run 25 runs were skipped and one run failed due to\r\nan unrelated test.\r\n\r\nCloses https://github.com/elastic/kibana/issues/193868","sha":"92430b5aae3911a4278983415cc73aacfb3e924b"}}]}] BACKPORT--> Co-authored-by: Matthew Kime <matt@mattki.me>
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 1, 2024
## Summary The test no longer appears flaky based on the flaky test runner. In addition to this PR there's also elastic#197563 for 400+ passes. It should be noted that in one run 25 runs were skipped and one run failed due to an unrelated test. Closes elastic#193868
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers