-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Removing use of ignore_throttled #199107
[ML] Removing use of ignore_throttled #199107
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested (cloning jobs created previously with ignore_throttled
in the datafeed config) and LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
ignore_throttled
is being removed, we can remove it from the various searches we run.I'm leaving it in the schema for the datafeed config for now, just in case we have a situation where a very old job is used in the UI with an endpoint which validates the datafeed config. Even though the setting would be ignored, we don't want the route to reject the datafeed because it doesn't know what
ignore_throttled
is.When cloning very old jobs jobs, I'm removing
ignore_throttled
from theindices_options