Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Removing use of ignore_throttled #199107

Merged

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Nov 6, 2024

ignore_throttled is being removed, we can remove it from the various searches we run.

I'm leaving it in the schema for the datafeed config for now, just in case we have a situation where a very old job is used in the UI with an endpoint which validates the datafeed config. Even though the setting would be ignored, we don't want the route to reject the datafeed because it doesn't know what ignore_throttled is.

When cloning very old jobs jobs, I'm removing ignore_throttled from the indices_options

@jgowdyelastic jgowdyelastic marked this pull request as ready for review November 14, 2024 13:08
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner November 14, 2024 13:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (cloning jobs created previously with ignore_throttled in the datafeed config) and LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / RootPrivilegesCallout should render callout requiring root privileges
  • [job] [logs] Jest Tests #6 / useActionStatus should refresh statuses on refresh flag

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.7MB 4.7MB -252.0B

History

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit b1d3de2 into elastic:main Nov 22, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants