Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yml config for MKI pipeline #199422

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix yml config for MKI pipeline #199422

merged 1 commit into from
Nov 8, 2024

Conversation

nkhristinin
Copy link
Contributor

@nkhristinin nkhristinin commented Nov 8, 2024 •
edited by kibanamachine
Loading

Summary

this config isn't valid, and MKI pipeline is failing, as it can't parse it.

@nkhristinin nkhristinin requested a review from a team as a code owner November 8, 2024 08:59
@nkhristinin nkhristinin changed the title Fix yml config Fix yml config for MKI pipeline Nov 8, 2024
@nkhristinin nkhristinin added v9.0.0 backport:version Backport to applied version labels v8.17.0 release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Nov 8, 2024
pheyos
pheyos approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Checked the old file with a yaml validator and that failed (as expected and similar to how this pipeline upload fails) and with the fix from the PR the yaml validator passes.

@nkhristinin nkhristinin enabled auto-merge (squash) November 8, 2024 09:08
@nkhristinin nkhristinin merged commit fee03b6 into elastic:main Nov 8, 2024
44 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11740720616

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #36 / @ess @serverless SecuritySolution Explore Overview Overview Network With packetbeat Make sure that we get OverviewNetwork data
  • [job] [logs] FTR Configs #45 / @ess @serverless SecuritySolution Timeline @skipInServerless Timeline Details Make sure that we get kpi data
  • [job] [logs] Jest Tests #16 / AgentUpgradeStatus with agent upgrade details should render UPG_REQUESTED state correctly
  • [job] [logs] FTR Configs #99 / rules security and spaces enabled: basic ruleRegistryAlertsSearchStrategy discover should return alerts from .es-query rule type with consumer discover with access only to stack rules

Metrics [docs]

✅ unchanged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 8, 2024
@nkhristinin
Fix yml config for MKI pipeline (elastic#199422)
cdd26ae 
## Summary

this config isn't valid, and MKI pipeline is failing, as it can't parse
it.

(cherry picked from commit fee03b6)
@kibanamachine kibanamachine mentioned this pull request Nov 8, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 8, 2024
@kibanamachine @nkhristinin
[8.x] Fix yml config for MKI pipeline (#199422) (#199450)
43e8c02 
# Backport

This will backport the following commits from `main` to `8.x`:
- [Fix yml config for MKI pipeline
(#199422)](#199422)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"nikita.khristinin@elastic.co"},"sourceCommit":{"committedDate":"2024-11-08T10:48:37Z","message":"Fix
yml config for MKI pipeline (#199422)\n\n## Summary\r\n\r\nthis config
isn't valid, and MKI pipeline is failing, as it can't
parse\r\nit.","sha":"fee03b6c8dc86deb35a80f7c5606f38e823af384","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.17.0"],"title":"Fix
yml config for MKI
pipeline","number":199422,"url":"https://github.com/elastic/kibana/pull/199422","mergeCommit":{"message":"Fix
yml config for MKI pipeline (#199422)\n\n## Summary\r\n\r\nthis config
isn't valid, and MKI pipeline is failing, as it can't
parse\r\nit.","sha":"fee03b6c8dc86deb35a80f7c5606f38e823af384"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199422","number":199422,"mergeCommit":{"message":"Fix
yml config for MKI pipeline (#199422)\n\n## Summary\r\n\r\nthis config
isn't valid, and MKI pipeline is failing, as it can't
parse\r\nit.","sha":"fee03b6c8dc86deb35a80f7c5606f38e823af384"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Khristinin Nikita <nikita.khristinin@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 8, 2024
@nkhristinin @CAWilson94
Fix yml config for MKI pipeline (elastic#199422)
f838340 
## Summary

this config isn't valid, and MKI pipeline is failing, as it can't parse
it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delanni delanni delanni approved these changes

@pheyos pheyos pheyos approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nkhristinin @kibanamachine @elasticmachine @pheyos @delanni