-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Custom threshold] Fix the custom equation label on the preview lens chart #199618
[Custom threshold] Fix the custom equation label on the preview lens chart #199618
Conversation
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11796811441 |
…chart (elastic#199618) Fixes elastic#181876 ## Summary This PR fixes the custom equation label on the preview lens chart. |With label|Without label|With group by field| |---|---|---| |![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)| (cherry picked from commit 8668757)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… lens chart (#199618) (#199770) # Backport This will backport the following commits from `main` to `8.x`: - [[Custom threshold] Fix the custom equation label on the preview lens chart (#199618)](#199618) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2024-11-12T12:01:36Z","message":"[Custom threshold] Fix the custom equation label on the preview lens chart (#199618)\n\nFixes #181876\r\n\r\n## Summary\r\n\r\nThis PR fixes the custom equation label on the preview lens chart.\r\n\r\n|With label|Without label|With group by field|\r\n|---|---|---|\r\n\r\n|![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|","sha":"8668757459feca8b5792662d2dacd07b0bf94e74","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Custom threshold] Fix the custom equation label on the preview lens chart","number":199618,"url":"https://github.com/elastic/kibana/pull/199618","mergeCommit":{"message":"[Custom threshold] Fix the custom equation label on the preview lens chart (#199618)\n\nFixes #181876\r\n\r\n## Summary\r\n\r\nThis PR fixes the custom equation label on the preview lens chart.\r\n\r\n|With label|Without label|With group by field|\r\n|---|---|---|\r\n\r\n|![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|","sha":"8668757459feca8b5792662d2dacd07b0bf94e74"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199618","number":199618,"mergeCommit":{"message":"[Custom threshold] Fix the custom equation label on the preview lens chart (#199618)\n\nFixes #181876\r\n\r\n## Summary\r\n\r\nThis PR fixes the custom equation label on the preview lens chart.\r\n\r\n|With label|Without label|With group by field|\r\n|---|---|---|\r\n\r\n|![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|","sha":"8668757459feca8b5792662d2dacd07b0bf94e74"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
…chart (elastic#199618) Fixes elastic#181876 ## Summary This PR fixes the custom equation label on the preview lens chart. |With label|Without label|With group by field| |---|---|---| |![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|
…chart (elastic#199618) Fixes elastic#181876 ## Summary This PR fixes the custom equation label on the preview lens chart. |With label|Without label|With group by field| |---|---|---| |![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|
Fixes #181876
Summary
This PR fixes the custom equation label on the preview lens chart.