Merge stored/index fields into _formatted #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 19, 2014 15:36
| @@ -264,6 +264,8 @@ define(function (require) { | |||
| 'match_all': {} | |||
| }; | |||
| } | |||
| flatState.body.fields = ['*', '_source']; | |||
There was a problem hiding this comment.
I'm curious why this doesn't return a lot more data than it is. By including _source here does it prevent fields that are already in source from being sent as fields?
|
LGTM! |
spalger
pushed a commit
that referenced
this pull request
Nov 21, 2014
Merge stored/index fields into _formatted
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this was to close #1766 in which
_timestampwas not working. The reason_timestampdoesn't work is because it is never returned, unless it isstore: trueand you explicitly ask for it. The pull does the following to resolve the issue:_timestampto bedate, since it always is and must be. This makes sure it is formatted as a date and is available for date_histogram aggs.