Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Address chart performance issues for non-transformational and non-time-based ES|QL queries #200583

Merged
merged 10 commits into from
Nov 21, 2024
Merged

[Discover] Address chart performance issues for non-transformational and non-time-based ES|QL queries #200583

merged 10 commits into from
Nov 21, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Nov 18, 2024 •
edited by kibanamachine
Loading

Summary

This PR changes the logic around when suggestions from lens API are used. Previously for non-transformational query and non-time-based data it would try to render one of lens suggestions supplying chart data via table prop. Now, it would not render any chart.

Before:

  • Data view mode => Static histogram configuration
  • ES|QL mode and non-transformational query => Gets lens suggestions. If histogram chart is not possible, takes the first lens suggestion for rendering the chart
  • ES|QL mode and transformational query => Gets lens suggestions. Takes the first lens suggestion for rendering the chart.

After:

  • Data view mode => Static histogram configuration (same)
  • ES|QL mode and non-transformational query => Gets lens suggestions. If histogram chart is not possible, renders nothing (updated)
  • ES|QL mode and transformational query => Gets lens suggestions. Takes the first lens suggestion for rendering the chart. (same)

Testing

As per originally reported case:

  1. node scripts/es_archiver --kibana-url=http://elastic:changeme@localhost:5601 --es-url=http://elastic:changeme@localhost:9200 load test/functional/fixtures/es_archiver/many_fields

  2. Navigate to Discover, switch to ES|QL mode and enter FROM indices-stats | LIMIT 10

  3. No chart is expected.

Also there should be no regression for #195863

Checklist

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 18, 2024
@jughosta jughosta self-assigned this Nov 18, 2024
jughosta
jughosta commented Nov 18, 2024
View reviewed changes
src/plugins/unified_histogram/public/services/lens_vis_service.ts
@@ -609,13 +606,17 @@ export class LensVisService {
}): Suggestion[] => {
const { dataView, columns, query, isPlainRecord } = queryParams;

if (!isPlainRecord || !isOfAggregateQueryType(query)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style updates. Same logic.

jughosta
jughosta commented Nov 18, 2024
View reviewed changes
src/plugins/unified_histogram/public/services/lens_vis_service.ts
timeRange &&
isOfAggregateQueryType(query) &&
!hasTransformationalCommand(query.esql)
) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style updates. Same logic.

jughosta
jughosta commented Nov 18, 2024
View reviewed changes
src/plugins/unified_histogram/public/layout/helpers.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this wrapper-function

@jughosta jughosta marked this pull request as ready for review November 19, 2024 09:41
@jughosta jughosta requested a review from a team as a code owner November 19, 2024 09:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta jughosta requested a review from stratoula November 19, 2024 09:41
@jughosta jughosta mentioned this pull request Nov 19, 2024
Merged
74 tasks
@stratoula stratoula added the Feature:ES|QL ES|QL related features in Kibana label Nov 20, 2024
davismcphee
davismcphee approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good and it works as expected. Thanks for fixing it!

@stratoula stratoula added v9.0.0 backport:version Backport to applied version labels v8.17.0 v8.18.0 and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 21, 2024
stratoula
stratoula approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Julia thanx for taking care of it!

I twitched the labels a bit to backport in 8.17 too

kertal
kertal approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @jughosta for fixing this so quickly 🙏 , just tested the many_fields index again, no more chart rendered, no more performance issues.

One question: I think this should be labeled as a fix, shouldn't it?

@stratoula stratoula added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 21, 2024
@stratoula
Copy link
Contributor

@kertal totally, I update the release label

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / package card should navigate with state when integrations card

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
unifiedHistogram 194 193 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedHistogram 71.4KB 71.3KB -92.0B

History

cc @jughosta

@jughosta
Copy link
Contributor Author

@kertal @stratoula

Yes, thanks for the review and updating the labels!

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7457

[✅] test/functional/apps/discover/group3/config.ts: 25/25 tests passed.

see run history

@jughosta jughosta merged commit b9439e6 into elastic:main Nov 21, 2024
36 checks passed
@jughosta jughosta deleted the 199608-refactor-suggestions-usage branch November 21, 2024 13:10
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/11953911168

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 21, 2024
@jughosta
[Discover] Address chart performance issues for non-transformational …
7649bba 
…and non-time-based ES|QL queries (elastic#200583)

- Closes elastic#199608

## Summary

This PR changes the logic around when suggestions from lens API are
used. Previously for non-transformational query and non-time-based data
it would try to render one of lens suggestions supplying chart data via
`table` prop. Now, it would not render any chart.

Before:
- Data view mode => Static histogram configuration
- ES|QL mode and non-transformational query => _**Gets lens
suggestions.**_ If histogram chart is not possible, **_takes the first
lens suggestion for rendering the chart_**
- ES|QL mode and transformational query => Gets lens suggestions. Takes
the first lens suggestion for rendering the chart.

After:
- Data view mode => Static histogram configuration (same)
- ES|QL mode and non-transformational query => ~~_**Gets lens
suggestions.**_~~ If histogram chart is not possible, **_renders
nothing_** (updated)
- ES|QL mode and transformational query => Gets lens suggestions. Takes
the first lens suggestion for rendering the chart. (same)

### Testing

As per originally reported case:
1. `node scripts/es_archiver
--kibana-url=http://elastic:changeme@localhost:5601
--es-url=http://elastic:changeme@localhost:9200 load
test/functional/fixtures/es_archiver/many_fields`

2. Navigate to Discover, switch to ES|QL mode and enter `FROM
indices-stats | LIMIT 10`
3. No chart is expected.

Also there should be no regression for
elastic#195863

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
(cherry picked from commit b9439e6)
@kibanamachine kibanamachine mentioned this pull request Nov 21, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 21, 2024
@jughosta
[Discover] Address chart performance issues for non-transformational …
a1e54ee 
…and non-time-based ES|QL queries (elastic#200583)

- Closes elastic#199608

## Summary

This PR changes the logic around when suggestions from lens API are
used. Previously for non-transformational query and non-time-based data
it would try to render one of lens suggestions supplying chart data via
`table` prop. Now, it would not render any chart.

Before:
- Data view mode => Static histogram configuration
- ES|QL mode and non-transformational query => _**Gets lens
suggestions.**_ If histogram chart is not possible, **_takes the first
lens suggestion for rendering the chart_**
- ES|QL mode and transformational query => Gets lens suggestions. Takes
the first lens suggestion for rendering the chart.

After:
- Data view mode => Static histogram configuration (same)
- ES|QL mode and non-transformational query => ~~_**Gets lens
suggestions.**_~~ If histogram chart is not possible, **_renders
nothing_** (updated)
- ES|QL mode and transformational query => Gets lens suggestions. Takes
the first lens suggestion for rendering the chart. (same)

### Testing

As per originally reported case:
1. `node scripts/es_archiver
--kibana-url=http://elastic:changeme@localhost:5601
--es-url=http://elastic:changeme@localhost:9200 load
test/functional/fixtures/es_archiver/many_fields`

2. Navigate to Discover, switch to ES|QL mode and enter `FROM
indices-stats | LIMIT 10`
3. No chart is expected.

Also there should be no regression for
elastic#195863

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
(cherry picked from commit b9439e6)
@kibanamachine kibanamachine mentioned this pull request Nov 21, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.17
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 21, 2024
@kibanamachine @jughosta
[8.x] [Discover] Address chart performance issues for non-transformat…
c832adb 
…ional and non-time-based ES|QL queries (#200583) (#201185)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Discover] Address chart performance issues for non-transformational
and non-time-based ES|QL queries
(#200583)](#200583)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-11-21T13:10:21Z","message":"[Discover]
Address chart performance issues for non-transformational and
non-time-based ES|QL queries (#200583)\n\n- Closes
https://github.com/elastic/kibana/issues/199608\r\n\r\n##
Summary\r\n\r\nThis PR changes the logic around when suggestions from
lens API are\r\nused. Previously for non-transformational query and
non-time-based data\r\nit would try to render one of lens suggestions
supplying chart data via\r\n`table` prop. Now, it would not render any
chart.\r\n\r\nBefore:\r\n- Data view mode => Static histogram
configuration\r\n- ES|QL mode and non-transformational query => _**Gets
lens\r\nsuggestions.**_ If histogram chart is not possible, **_takes the
first\r\nlens suggestion for rendering the chart_**\r\n- ES|QL mode and
transformational query => Gets lens suggestions. Takes\r\nthe first lens
suggestion for rendering the chart.\r\n\r\nAfter:\r\n- Data view mode =>
Static histogram configuration (same)\r\n- ES|QL mode and
non-transformational query => ~~_**Gets lens\r\nsuggestions.**_~~ If
histogram chart is not possible, **_renders\r\nnothing_** (updated)\r\n-
ES|QL mode and transformational query => Gets lens suggestions.
Takes\r\nthe first lens suggestion for rendering the chart.
(same)\r\n\r\n### Testing\r\n\r\nAs per originally reported case:\r\n1.
`node
scripts/es_archiver\r\n--kibana-url=http://elastic:changeme@localhost:5601\r\n--es-url=http://elastic:changeme@localhost:9200
load\r\ntest/functional/fixtures/es_archiver/many_fields`\r\n\r\n2.
Navigate to Discover, switch to ES|QL mode and enter
`FROM\r\nindices-stats | LIMIT 10`\r\n3. No chart is
expected.\r\n\r\nAlso there should be no regression
for\r\nhttps://github.com//pull/195863\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Davis McPhee
<davis.mcphee@elastic.co>\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"b9439e658d5cca8dd89f7b3d7cc399c72e4e5103","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:DataDiscovery","Feature:ES|QL","backport:version","v8.17.0","v8.18.0"],"title":"[Discover]
Address chart performance issues for non-transformational and
non-time-based ES|QL
queries","number":200583,"url":"https://github.com/elastic/kibana/pull/200583","mergeCommit":{"message":"[Discover]
Address chart performance issues for non-transformational and
non-time-based ES|QL queries (#200583)\n\n- Closes
https://github.com/elastic/kibana/issues/199608\r\n\r\n##
Summary\r\n\r\nThis PR changes the logic around when suggestions from
lens API are\r\nused. Previously for non-transformational query and
non-time-based data\r\nit would try to render one of lens suggestions
supplying chart data via\r\n`table` prop. Now, it would not render any
chart.\r\n\r\nBefore:\r\n- Data view mode => Static histogram
configuration\r\n- ES|QL mode and non-transformational query => _**Gets
lens\r\nsuggestions.**_ If histogram chart is not possible, **_takes the
first\r\nlens suggestion for rendering the chart_**\r\n- ES|QL mode and
transformational query => Gets lens suggestions. Takes\r\nthe first lens
suggestion for rendering the chart.\r\n\r\nAfter:\r\n- Data view mode =>
Static histogram configuration (same)\r\n- ES|QL mode and
non-transformational query => ~~_**Gets lens\r\nsuggestions.**_~~ If
histogram chart is not possible, **_renders\r\nnothing_** (updated)\r\n-
ES|QL mode and transformational query => Gets lens suggestions.
Takes\r\nthe first lens suggestion for rendering the chart.
(same)\r\n\r\n### Testing\r\n\r\nAs per originally reported case:\r\n1.
`node
scripts/es_archiver\r\n--kibana-url=http://elastic:changeme@localhost:5601\r\n--es-url=http://elastic:changeme@localhost:9200
load\r\ntest/functional/fixtures/es_archiver/many_fields`\r\n\r\n2.
Navigate to Discover, switch to ES|QL mode and enter
`FROM\r\nindices-stats | LIMIT 10`\r\n3. No chart is
expected.\r\n\r\nAlso there should be no regression
for\r\nhttps://github.com//pull/195863\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Davis McPhee
<davis.mcphee@elastic.co>\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"b9439e658d5cca8dd89f7b3d7cc399c72e4e5103"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200583","number":200583,"mergeCommit":{"message":"[Discover]
Address chart performance issues for non-transformational and
non-time-based ES|QL queries (#200583)\n\n- Closes
https://github.com/elastic/kibana/issues/199608\r\n\r\n##
Summary\r\n\r\nThis PR changes the logic around when suggestions from
lens API are\r\nused. Previously for non-transformational query and
non-time-based data\r\nit would try to render one of lens suggestions
supplying chart data via\r\n`table` prop. Now, it would not render any
chart.\r\n\r\nBefore:\r\n- Data view mode => Static histogram
configuration\r\n- ES|QL mode and non-transformational query => _**Gets
lens\r\nsuggestions.**_ If histogram chart is not possible, **_takes the
first\r\nlens suggestion for rendering the chart_**\r\n- ES|QL mode and
transformational query => Gets lens suggestions. Takes\r\nthe first lens
suggestion for rendering the chart.\r\n\r\nAfter:\r\n- Data view mode =>
Static histogram configuration (same)\r\n- ES|QL mode and
non-transformational query => ~~_**Gets lens\r\nsuggestions.**_~~ If
histogram chart is not possible, **_renders\r\nnothing_** (updated)\r\n-
ES|QL mode and transformational query => Gets lens suggestions.
Takes\r\nthe first lens suggestion for rendering the chart.
(same)\r\n\r\n### Testing\r\n\r\nAs per originally reported case:\r\n1.
`node
scripts/es_archiver\r\n--kibana-url=http://elastic:changeme@localhost:5601\r\n--es-url=http://elastic:changeme@localhost:9200
load\r\ntest/functional/fixtures/es_archiver/many_fields`\r\n\r\n2.
Navigate to Discover, switch to ES|QL mode and enter
`FROM\r\nindices-stats | LIMIT 10`\r\n3. No chart is
expected.\r\n\r\nAlso there should be no regression
for\r\nhttps://github.com//pull/195863\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Davis McPhee
<davis.mcphee@elastic.co>\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"b9439e658d5cca8dd89f7b3d7cc399c72e4e5103"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kibanamachine added a commit that referenced this pull request Nov 21, 2024
@kibanamachine @jughosta
[8.17] [Discover] Address chart performance issues for non-transforma…
b5c5948 
…tional and non-time-based ES|QL queries (#200583) (#201184)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Discover] Address chart performance issues for non-transformational
and non-time-based ES|QL queries
(#200583)](#200583)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-11-21T13:10:21Z","message":"[Discover]
Address chart performance issues for non-transformational and
non-time-based ES|QL queries (#200583)\n\n- Closes
https://github.com/elastic/kibana/issues/199608\r\n\r\n##
Summary\r\n\r\nThis PR changes the logic around when suggestions from
lens API are\r\nused. Previously for non-transformational query and
non-time-based data\r\nit would try to render one of lens suggestions
supplying chart data via\r\n`table` prop. Now, it would not render any
chart.\r\n\r\nBefore:\r\n- Data view mode => Static histogram
configuration\r\n- ES|QL mode and non-transformational query => _**Gets
lens\r\nsuggestions.**_ If histogram chart is not possible, **_takes the
first\r\nlens suggestion for rendering the chart_**\r\n- ES|QL mode and
transformational query => Gets lens suggestions. Takes\r\nthe first lens
suggestion for rendering the chart.\r\n\r\nAfter:\r\n- Data view mode =>
Static histogram configuration (same)\r\n- ES|QL mode and
non-transformational query => ~~_**Gets lens\r\nsuggestions.**_~~ If
histogram chart is not possible, **_renders\r\nnothing_** (updated)\r\n-
ES|QL mode and transformational query => Gets lens suggestions.
Takes\r\nthe first lens suggestion for rendering the chart.
(same)\r\n\r\n### Testing\r\n\r\nAs per originally reported case:\r\n1.
`node
scripts/es_archiver\r\n--kibana-url=http://elastic:changeme@localhost:5601\r\n--es-url=http://elastic:changeme@localhost:9200
load\r\ntest/functional/fixtures/es_archiver/many_fields`\r\n\r\n2.
Navigate to Discover, switch to ES|QL mode and enter
`FROM\r\nindices-stats | LIMIT 10`\r\n3. No chart is
expected.\r\n\r\nAlso there should be no regression
for\r\nhttps://github.com//pull/195863\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Davis McPhee
<davis.mcphee@elastic.co>\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"b9439e658d5cca8dd89f7b3d7cc399c72e4e5103","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:DataDiscovery","Feature:ES|QL","backport:version","v8.17.0","v8.18.0"],"title":"[Discover]
Address chart performance issues for non-transformational and
non-time-based ES|QL
queries","number":200583,"url":"https://github.com/elastic/kibana/pull/200583","mergeCommit":{"message":"[Discover]
Address chart performance issues for non-transformational and
non-time-based ES|QL queries (#200583)\n\n- Closes
https://github.com/elastic/kibana/issues/199608\r\n\r\n##
Summary\r\n\r\nThis PR changes the logic around when suggestions from
lens API are\r\nused. Previously for non-transformational query and
non-time-based data\r\nit would try to render one of lens suggestions
supplying chart data via\r\n`table` prop. Now, it would not render any
chart.\r\n\r\nBefore:\r\n- Data view mode => Static histogram
configuration\r\n- ES|QL mode and non-transformational query => _**Gets
lens\r\nsuggestions.**_ If histogram chart is not possible, **_takes the
first\r\nlens suggestion for rendering the chart_**\r\n- ES|QL mode and
transformational query => Gets lens suggestions. Takes\r\nthe first lens
suggestion for rendering the chart.\r\n\r\nAfter:\r\n- Data view mode =>
Static histogram configuration (same)\r\n- ES|QL mode and
non-transformational query => ~~_**Gets lens\r\nsuggestions.**_~~ If
histogram chart is not possible, **_renders\r\nnothing_** (updated)\r\n-
ES|QL mode and transformational query => Gets lens suggestions.
Takes\r\nthe first lens suggestion for rendering the chart.
(same)\r\n\r\n### Testing\r\n\r\nAs per originally reported case:\r\n1.
`node
scripts/es_archiver\r\n--kibana-url=http://elastic:changeme@localhost:5601\r\n--es-url=http://elastic:changeme@localhost:9200
load\r\ntest/functional/fixtures/es_archiver/many_fields`\r\n\r\n2.
Navigate to Discover, switch to ES|QL mode and enter
`FROM\r\nindices-stats | LIMIT 10`\r\n3. No chart is
expected.\r\n\r\nAlso there should be no regression
for\r\nhttps://github.com//pull/195863\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Davis McPhee
<davis.mcphee@elastic.co>\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"b9439e658d5cca8dd89f7b3d7cc399c72e4e5103"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200583","number":200583,"mergeCommit":{"message":"[Discover]
Address chart performance issues for non-transformational and
non-time-based ES|QL queries (#200583)\n\n- Closes
https://github.com/elastic/kibana/issues/199608\r\n\r\n##
Summary\r\n\r\nThis PR changes the logic around when suggestions from
lens API are\r\nused. Previously for non-transformational query and
non-time-based data\r\nit would try to render one of lens suggestions
supplying chart data via\r\n`table` prop. Now, it would not render any
chart.\r\n\r\nBefore:\r\n- Data view mode => Static histogram
configuration\r\n- ES|QL mode and non-transformational query => _**Gets
lens\r\nsuggestions.**_ If histogram chart is not possible, **_takes the
first\r\nlens suggestion for rendering the chart_**\r\n- ES|QL mode and
transformational query => Gets lens suggestions. Takes\r\nthe first lens
suggestion for rendering the chart.\r\n\r\nAfter:\r\n- Data view mode =>
Static histogram configuration (same)\r\n- ES|QL mode and
non-transformational query => ~~_**Gets lens\r\nsuggestions.**_~~ If
histogram chart is not possible, **_renders\r\nnothing_** (updated)\r\n-
ES|QL mode and transformational query => Gets lens suggestions.
Takes\r\nthe first lens suggestion for rendering the chart.
(same)\r\n\r\n### Testing\r\n\r\nAs per originally reported case:\r\n1.
`node
scripts/es_archiver\r\n--kibana-url=http://elastic:changeme@localhost:5601\r\n--es-url=http://elastic:changeme@localhost:9200
load\r\ntest/functional/fixtures/es_archiver/many_fields`\r\n\r\n2.
Navigate to Discover, switch to ES|QL mode and enter
`FROM\r\nindices-stats | LIMIT 10`\r\n3. No chart is
expected.\r\n\r\nAlso there should be no regression
for\r\nhttps://github.com//pull/195863\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Davis McPhee
<davis.mcphee@elastic.co>\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"b9439e658d5cca8dd89f7b3d7cc399c72e4e5103"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@jughosta @davismcphee
@stratoula @paulinashakirova
[Discover] Address chart performance issues for non-transformational …
89fc4d2 
…and non-time-based ES|QL queries (elastic#200583)

- Closes elastic#199608

## Summary

This PR changes the logic around when suggestions from lens API are
used. Previously for non-transformational query and non-time-based data
it would try to render one of lens suggestions supplying chart data via
`table` prop. Now, it would not render any chart.

Before:
- Data view mode => Static histogram configuration
- ES|QL mode and non-transformational query => _**Gets lens
suggestions.**_ If histogram chart is not possible, **_takes the first
lens suggestion for rendering the chart_**
- ES|QL mode and transformational query => Gets lens suggestions. Takes
the first lens suggestion for rendering the chart.

After:
- Data view mode => Static histogram configuration (same)
- ES|QL mode and non-transformational query => ~~_**Gets lens
suggestions.**_~~ If histogram chart is not possible, **_renders
nothing_** (updated)
- ES|QL mode and transformational query => Gets lens suggestions. Takes
the first lens suggestion for rendering the chart. (same)

### Testing

As per originally reported case:
1. `node scripts/es_archiver
--kibana-url=http://elastic:changeme@localhost:5601
--es-url=http://elastic:changeme@localhost:9200 load
test/functional/fixtures/es_archiver/many_fields`

2. Navigate to Discover, switch to ES|QL mode and enter `FROM
indices-stats | LIMIT 10`
3. No chart is expected.

Also there should be no regression for
elastic#195863

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@jughosta @davismcphee
@stratoula @CAWilson94
[Discover] Address chart performance issues for non-transformational …
80644ae 
…and non-time-based ES|QL queries (elastic#200583)

- Closes elastic#199608

## Summary

This PR changes the logic around when suggestions from lens API are
used. Previously for non-transformational query and non-time-based data
it would try to render one of lens suggestions supplying chart data via
`table` prop. Now, it would not render any chart.

Before:
- Data view mode => Static histogram configuration
- ES|QL mode and non-transformational query => _**Gets lens
suggestions.**_ If histogram chart is not possible, **_takes the first
lens suggestion for rendering the chart_**
- ES|QL mode and transformational query => Gets lens suggestions. Takes
the first lens suggestion for rendering the chart.

After:
- Data view mode => Static histogram configuration (same)
- ES|QL mode and non-transformational query => ~~_**Gets lens
suggestions.**_~~ If histogram chart is not possible, **_renders
nothing_** (updated)
- ES|QL mode and transformational query => Gets lens suggestions. Takes
the first lens suggestion for rendering the chart. (same)

### Testing

As per originally reported case:
1. `node scripts/es_archiver
--kibana-url=http://elastic:changeme@localhost:5601
--es-url=http://elastic:changeme@localhost:9200 load
test/functional/fixtures/es_archiver/many_fields`

2. Navigate to Discover, switch to ES|QL mode and enter `FROM
indices-stats | LIMIT 10`
3. No chart is expected.

Also there should be no regression for
elastic#195863

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

@stratoula stratoula stratoula approved these changes

@kertal kertal kertal approved these changes

Assignees

@jughosta jughosta

Labels
backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover][ES|QL] Performance troubles when there are lots of fields
6 participants
@jughosta @elasticmachine @stratoula @kibanamachine @kertal @davismcphee