Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Fixed an issue with Host.name Alerts contextual flyout #200626

Merged
merged 3 commits into from
Nov 19, 2024
Merged

[Cloud Security] Fixed an issue with Host.name Alerts contextual flyout #200626

merged 3 commits into from
Nov 19, 2024

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Nov 18, 2024 •
edited by kibanamachine
Loading

Summary

This PR addresses issue with Alerts flyout on host.name. Users are unable to to open Flyout via clicking Expand flyout (Missing this) and also unable to close Alerts datagrid

Issue

Screenshot 2024-11-18 at 9 43 24 AM

Fix

Screenshot 2024-11-18 at 9 44 05 AM

@animehart animehart added v9.0.0 v8.17.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related labels Nov 18, 2024
@animehart animehart marked this pull request as ready for review November 18, 2024 17:46
@animehart animehart requested a review from a team as a code owner November 18, 2024 17:46
@animehart animehart requested a review from tiansivive November 18, 2024 17:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@animehart animehart requested a review from maxcold November 18, 2024 17:47
@animehart animehart mentioned this pull request Nov 18, 2024
Merged
@animehart animehart requested a review from a team as a code owner November 19, 2024 00:05
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@albertoblaz albertoblaz added the backport:version Backport to applied version labels label Nov 19, 2024
@maxcold maxcold merged commit e05d834 into elastic:main Nov 19, 2024
45 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11909919186

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 19, 2024
@animehart
[Cloud Security] Fixed an issue with Host.name Alerts contextual flyo…
77d0a8b 
…ut (elastic#200626)

## Summary

This PR addresses issue with Alerts flyout on host.name. Users are
unable to to open Flyout via clicking Expand flyout (Missing this) and
also unable to close Alerts datagrid

## Issue
<img width="1728" alt="Screenshot 2024-11-18 at 9 43 24 AM"
src="https://github.com/user-attachments/assets/768729ac-b7e7-4bac-a6a6-253ad183b4bb">

## Fix
<img width="1725" alt="Screenshot 2024-11-18 at 9 44 05 AM"
src="https://github.com/user-attachments/assets/25044a1c-924f-48f1-8f41-51d5f5797b28">

(cherry picked from commit e05d834)
@kibanamachine kibanamachine mentioned this pull request Nov 19, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Nov 19, 2024
Merged
2 tasks
kibanamachine added a commit that referenced this pull request Nov 19, 2024
@kibanamachine @animehart
[8.x] [Cloud Security] Fixed an issue with Host.name Alerts contextua…
1cd1b5c 
…l flyout (#200626) (#200688)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cloud Security] Fixed an issue with Host.name Alerts contextual
flyout (#200626)](#200626)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rickyanto
Ang","email":"rickyangwyn@gmail.com"},"sourceCommit":{"committedDate":"2024-11-19T09:20:37Z","message":"[Cloud
Security] Fixed an issue with Host.name Alerts contextual flyout
(#200626)\n\n## Summary\r\n\r\nThis PR addresses issue with Alerts
flyout on host.name. Users are\r\nunable to to open Flyout via clicking
Expand flyout (Missing this) and\r\nalso unable to close Alerts
datagrid\r\n\r\n## Issue\r\n<img width=\"1728\" alt=\"Screenshot
2024-11-18 at 9 43
24 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/768729ac-b7e7-4bac-a6a6-253ad183b4bb\">\r\n\r\n##
Fix\r\n<img width=\"1725\" alt=\"Screenshot 2024-11-18 at 9 44
05 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/25044a1c-924f-48f1-8f41-51d5f5797b28\">","sha":"e05d83486b7f2229940d2c4d90549bf84cd23585","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud
Security","backport:prev-minor","backport:version","v8.17.0"],"title":"[Cloud
Security] Fixed an issue with Host.name Alerts contextual
flyout","number":200626,"url":"https://github.com/elastic/kibana/pull/200626","mergeCommit":{"message":"[Cloud
Security] Fixed an issue with Host.name Alerts contextual flyout
(#200626)\n\n## Summary\r\n\r\nThis PR addresses issue with Alerts
flyout on host.name. Users are\r\nunable to to open Flyout via clicking
Expand flyout (Missing this) and\r\nalso unable to close Alerts
datagrid\r\n\r\n## Issue\r\n<img width=\"1728\" alt=\"Screenshot
2024-11-18 at 9 43
24 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/768729ac-b7e7-4bac-a6a6-253ad183b4bb\">\r\n\r\n##
Fix\r\n<img width=\"1725\" alt=\"Screenshot 2024-11-18 at 9 44
05 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/25044a1c-924f-48f1-8f41-51d5f5797b28\">","sha":"e05d83486b7f2229940d2c4d90549bf84cd23585"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200626","number":200626,"mergeCommit":{"message":"[Cloud
Security] Fixed an issue with Host.name Alerts contextual flyout
(#200626)\n\n## Summary\r\n\r\nThis PR addresses issue with Alerts
flyout on host.name. Users are\r\nunable to to open Flyout via clicking
Expand flyout (Missing this) and\r\nalso unable to close Alerts
datagrid\r\n\r\n## Issue\r\n<img width=\"1728\" alt=\"Screenshot
2024-11-18 at 9 43
24 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/768729ac-b7e7-4bac-a6a6-253ad183b4bb\">\r\n\r\n##
Fix\r\n<img width=\"1725\" alt=\"Screenshot 2024-11-18 at 9 44
05 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/25044a1c-924f-48f1-8f41-51d5f5797b28\">","sha":"e05d83486b7f2229940d2c4d90549bf84cd23585"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Rickyanto Ang <rickyangwyn@gmail.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@animehart @CAWilson94
[Cloud Security] Fixed an issue with Host.name Alerts contextual flyo…
d1333cf 
…ut (elastic#200626)

## Summary

This PR addresses issue with Alerts flyout on host.name. Users are
unable to to open Flyout via clicking Expand flyout (Missing this) and
also unable to close Alerts datagrid

## Issue
<img width="1728" alt="Screenshot 2024-11-18 at 9 43 24 AM"
src="https://github.com/user-attachments/assets/768729ac-b7e7-4bac-a6a6-253ad183b4bb">

## Fix
<img width="1725" alt="Screenshot 2024-11-18 at 9 44 05 AM"
src="https://github.com/user-attachments/assets/25044a1c-924f-48f1-8f41-51d5f5797b28">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiansivive tiansivive tiansivive approved these changes

@albertoblaz albertoblaz albertoblaz approved these changes

@maxcold maxcold maxcold approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@animehart @elasticmachine @kibanamachine @maxcold @albertoblaz @tiansivive