New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [ML] Migrate influencers list from SCSS to Emotion (#200019) #200824

Merged

kibanamachine merged 1 commit into elastic:8.x from kibanamachine:backport/8.x/pr-200019

Nov 20, 2024

Contributor

kibanamachine commented Nov 19, 2024

Backport

This will backport the following commits from main to 8.x:

[ML] Migrate influencers list from SCSS to Emotion (#200019)

Questions ?

Please refer to the Backport tool documentation


          [ML] Migrate influencers list from SCSS to Emotion (elastic#200019)

d4213a3

## Summary

Part of: [elastic#140695](elastic#140695)
Migrates SCSS to emotion for Influencers list.

| Before  | After |
| ------------- | ------------- |
|
![image](https://github.com/user-attachments/assets/1f85b2d1-5526-49b2-819d-525989b9c48d)
|
![image](https://github.com/user-attachments/assets/e1e5745e-d00a-4a51-ab93-b29ff71d8aef)
|
|
![image](https://github.com/user-attachments/assets/f1e8d594-8a9d-4f08-98bb-156e21abd1c6)
|
![image](https://github.com/user-attachments/assets/d55a2848-2c28-4b4b-88b2-ed1b98b16430)
|

(cherry picked from commit 9162fde)

kibanamachine assigned rbrtj

kibanamachine added the backport label

kibanamachine enabled auto-merge (squash)

November 19, 2024 22:29

kibanamachine mentioned this pull request

[ML] Migrate influencers list from SCSS to Emotion #200019

Merged

github-actions bot approved these changes

View reviewed changes

kibanamachine merged commit 2298269 into elastic:8.x

25 checks passed

Contributor

elasticmachine commented Nov 20, 2024

💛 Build succeeded, but was flaky

Buildkite Build
Commit: d4213a3

Failed CI Steps

FTR Configs #64

Test Failures

[job] [logs] FTR Configs #64 / maps app dashboard reporting: creates a map report PNG file matches the baseline image, using sample geo data

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	2135	2136	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	4.7MB	4.7MB	-2.3KB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels