[Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings #201163
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 21, 2024
Closed
JoseLuisGJ
changed the title
JoseLuisGJ
added
backport
release_note:fix
Project:Accessibility
v9.0.0
accessibility: keyboard navigation
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
JoseLuisGJ
added
backport:version
jedrazb
reviewed
Nov 22, 2024
...ublic/applications/enterprise_search_content/components/settings/default_settings_flyout.tsx
Outdated
Show resolved
Hide resolved
jedrazb
reviewed
Nov 22, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @JoseLuisGJ |
JoseLuisGJ
removed
v9.0.0
backport:prev-major
JoseLuisGJ
added
backport:prev-minor
jedrazb
approved these changes
Nov 22, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11974710776 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2024
…efault Settings (elastic#201163) ## Summary This PR solves the issues elastic#195951 and elastic#195942 getting the focus on the first interactive element as suggested which is the _ingest pipelines_ external link after pressing enter using the keyboard navigation either the _Reset_ or _Save_ buttons. With this the screen reader announces the _ingest pipelines_ content after any of those previous events.  (cherry picked from commit 56ee089)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Nov 22, 2024
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2024
…Save Default Settings (#201163) (#201404) # Backport This will backport the following commits from `main` to `8.x`: - [[Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings (#201163)](#201163) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"José Luis González","email":"joseluisgj@gmail.com"},"sourceCommit":{"committedDate":"2024-11-22T14:42:16Z","message":"[Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings (#201163)\n\n## Summary\r\n\r\nThis PR solves the issues\r\nhttps://github.com//issues/195951 and\r\nhttps://github.com//issues/195942 getting the focus on the\r\nfirst interactive element as suggested which is the _ingest pipelines_\r\nexternal link after pressing enter using the keyboard navigation either\r\nthe _Reset_ or _Save_ buttons. With this the screen reader announces the\r\n_ingest pipelines_ content after any of those previous events.\r\n\r\n","sha":"56ee08946c1bead9d44829a9adfb11700522e70f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","accessibility: keyboard navigation","backport:prev-minor"],"title":"[Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings","number":201163,"url":"https://github.com/elastic/kibana/pull/201163","mergeCommit":{"message":"[Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings (#201163)\n\n## Summary\r\n\r\nThis PR solves the issues\r\nhttps://github.com//issues/195951 and\r\nhttps://github.com//issues/195942 getting the focus on the\r\nfirst interactive element as suggested which is the _ingest pipelines_\r\nexternal link after pressing enter using the keyboard navigation either\r\nthe _Reset_ or _Save_ buttons. With this the screen reader announces the\r\n_ingest pipelines_ content after any of those previous events.\r\n\r\n","sha":"56ee08946c1bead9d44829a9adfb11700522e70f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201163","number":201163,"mergeCommit":{"message":"[Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings (#201163)\n\n## Summary\r\n\r\nThis PR solves the issues\r\nhttps://github.com//issues/195951 and\r\nhttps://github.com//issues/195942 getting the focus on the\r\nfirst interactive element as suggested which is the _ingest pipelines_\r\nexternal link after pressing enter using the keyboard navigation either\r\nthe _Reset_ or _Save_ buttons. With this the screen reader announces the\r\n_ingest pipelines_ content after any of those previous events.\r\n\r\n","sha":"56ee08946c1bead9d44829a9adfb11700522e70f"}}]}] BACKPORT--> Co-authored-by: José Luis González <joseluisgj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR solves the issues #195951 and #195942 getting the focus on the first interactive element as suggested which is the ingest pipelines external link after pressing enter using the keyboard navigation either the Reset or Save buttons. With this the screen reader announces the ingest pipelines content after any of those previous events.