Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip flaky vega test #20127

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Skip flaky vega test #20127

merged 1 commit into from
Jun 21, 2018

Conversation

tylersmalley
Copy link
Contributor

Skip flaky vega test
d7c3f64 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added test Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jun 21, 2018
@tylersmalley
Copy link
Contributor Author

@elastic/kibana-visualizations

timroes
timroes approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if test passes

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tylersmalley tylersmalley merged commit 937d141 into elastic:master Jun 21, 2018
@tylersmalley
Copy link
Contributor Author

I am not seeing this failure on the 6.x branch, so will not backport at this time.

@tylersmalley tylersmalley mentioned this pull request Jun 21, 2018
Closed
@tylersmalley
Copy link
Contributor Author

Follow-up issue: #20131

@nyurik
Copy link
Contributor

nyurik commented Jun 21, 2018

Thanks. What worries me is that this test was working fine for several months, and has never been "flaky". Now it clearly began catching something (the way one would expect unit tests to do). I do wonder how something that triggers it made it into master... confusing.

@timroes timroes mentioned this pull request Jul 4, 2018
Merged
timroes pushed a commit to timroes/kibana that referenced this pull request Jul 4, 2018
@tylersmalley @timroes
Skip flaky vega test (elastic#20127)
2c72efd 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@timroes
Copy link
Contributor

timroes commented Jul 4, 2018

That really looks like something weird is going on. It started just yesterday, that this test now also fails 6.x constantly. So I am disabling it also for 6.x. I went through the fail start and can't find anything specific or related there. Maybe it was related anyhow to an update of a browser or such?

timroes added a commit that referenced this pull request Jul 4, 2018
@timroes
Skip flaky vega test (#20127) (#20468)
f85af48 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) test v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tylersmalley @elasticmachine @nyurik @timroes