[Pipeline Viewer] [Monitoring] Rename config view to PipelineViewer #20230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
chore
v7.0.0
Team:Logstash
v6.4.0
Team:Monitoring
💚 Build Succeeded |
mattapperson
approved these changes
Jun 26, 2018
| @@ -30,8 +30,8 @@ uiModule.directive('monitoringLogstashPipelineViewer', ($injector) => { | |||
|
|
|||
| scope.$watch('pipeline', (updatedPipeline) => { | |||
| pipelineState.update(updatedPipeline); | |||
| const configViewer = ( | |||
| <ConfigViewer | |||
| const pipelineViewer = ( | |||
There was a problem hiding this comment.
I would recommend renaming this, or even better, it needn't be a variable, just put it into the render argument directly. too many bugs are caused by having 2 things only differentiated by casing.
This is just a recommendation
There was a problem hiding this comment.
Sure thing, I'm fine with that. I'll ping you with an update commit.
|
@mattapperson good for your 👀 94ceb41 |
|
LGTM |
|
@mattapperson sorry to make you review this PR again.. but after running |
💚 Build Succeeded |
justinkambic
added a commit
that referenced
this pull request
Jun 26, 2018
…20230) * Rename config view to PipelineViewer. * Remove unused className. * Remove unneeded variable. * Format file with prettier.
|
Backported to: |
justinkambic
deleted the
monitoring/rename-config-view-to-pipeline-viewer
branch
mattapperson
pushed a commit
that referenced
this pull request
Jun 28, 2018
…20230) * Rename config view to PipelineViewer. * Remove unused className. * Remove unneeded variable. * Format file with prettier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The goal here is to rename the Config Viewer component to Pipeline Viewer. We've decided to do this to help keep consistency for users and ourselves; the previous component has been removed for the foreseeable future, so we are wanting to not add a point of confusion. This component was named "Config Viewer" originally to distinguish it from the existing component, but we no longer need that distinction.
From a high level, the
config_viewcomponents were moved out of their own directory and into the home folder for PipelineViewer, where the old PV components used to live. Exports have been updated to mirror the way the old component was accessed.Resolves #20123
Testing This PR
There aren't any functional changes in this PR, so a simple smoke test and green CI should be sufficient.
if...elsebranch, with X-Pack Monitoring enabled.a. Pipeline Viewer loads
b. You are able to use Detail Drawer
c. You can collapse/expand branches