[PipelineViewer] Test PipelineViewer sub-components #20329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
test
v7.0.0
Team:Logstash
v6.4.0
Team:Monitoring
💔 Build Failed |
justinkambic
force-pushed
the
monitoring/test-pipeline-viewer-subcomponents
branch
2 times, most recently
from
87ece48 to
0baa8c0
Compare
💚 Build Succeeded |
justinkambic
force-pushed
the
monitoring/test-pipeline-viewer-subcomponents
branch
from
616a914 to
ad21850
Compare
💚 Build Succeeded |
justinkambic
force-pushed
the
monitoring/test-pipeline-viewer-subcomponents
branch
from
ad21850 to
0bf80b3
Compare
💔 Build Failed |
justinkambic
force-pushed
the
monitoring/test-pipeline-viewer-subcomponents
branch
from
0bf80b3 to
5c7a413
Compare
💚 Build Succeeded |
|
@mattapperson would you mind giving me a review on this when you get a chance? 😺 |
mattapperson
approved these changes
Jul 9, 2018
justinkambic
added a commit
that referenced
this pull request
Jul 9, 2018
* Rename config view to PipelineViewer. * Decouple CollapsibleStatement from if/else using props.children. * Add tests for PipelineViewer component. * Test Metric component. * Test CollapsibleStatement component. * Test PluginStatement component. * Test Queue component. * Test StatementListHeading component. * Test StatementSection component. Move StatementList component to dedicated file. * Test StatementList component. * Test Statement component. * Run prettier on edited files.
|
Backported to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds tests for the sub-components of the updated PipelineViewer view.
Do not review this PR until #20252 is merged, as it relies on the changes from that PR.
Testing this PR
The tests here achieve a fairly high degree of coverage of the components in question. If the tests are passing, review that the code is satisfactory.