Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Fix codeowners #203650

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[l10n] Fix codeowners #203650

merged 1 commit into from
Dec 10, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Dec 10, 2024

Summary

Updating codeowners to ensure that we don't trigger code reviews from @elastic/kibana-localization when labels are updated.

@afharo afharo self-assigned this Dec 10, 2024
@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Dec 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo requested review from a team December 10, 2024 17:12
@afharo afharo enabled auto-merge (squash) December 10, 2024 17:12
TinaHeiligers
TinaHeiligers approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afharo afharo mentioned this pull request Dec 10, 2024
Merged
1 task
@afharo afharo merged commit 15f453b into elastic:main Dec 10, 2024
16 checks passed
@afharo afharo deleted the l10n/fix-codeowners branch December 10, 2024 18:55
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / Case Owner Selection renders all options
  • [job] [logs] FTR Configs #81 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Bootstrap Prebuilt Rules should skip installing fleet packages if they are already installed

Metrics [docs]

✅ unchanged

cc @afharo

@afharo afharo mentioned this pull request Dec 12, 2024
Merged
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@afharo @CAWilson94
[l10n] Fix codeowners (elastic#203650)
fe2890a 
## Summary

Updating codeowners to ensure that we don't trigger code reviews from
`@elastic/kibana-localization` when labels are updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@Bamieh Bamieh Bamieh approved these changes

Assignees

@afharo afharo

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afharo @elasticmachine @Bamieh @TinaHeiligers @kibanamachine