[WIP] Make apps responsible for executing their own searches #20395
Conversation
💔 Build Failed |
|
To be honest I find this a bit hard to read, since we did all that variable renaming in this PR too. Do you think it would be possible creating a single PR (I don't even mind if tests run on this one), that just shows the actual conceptional changes you want to show, without adding a lot of renaming? Update: I think I found all the relevant changes, and from the visualization point of view, this looks like it won't be any problems with regards to the new pipeline. |
| }; | ||
|
|
||
| $scope.fetch = _.debounce(fetch, 100); | ||
| courier.setSearchCallback(fetch); |
There was a problem hiding this comment.
As far as I understand this will only set a single callback to be executed when the update timer fires? That won't work imho, since the <visualize> can exist several times (on a dashboard), and it could also exist besides some saved searches. Doesn't ALL those need to have their fetch triggered? So wouldn't we need a Set of listeners here instead of a single one?
… execute its search. - Remove fetchSoon, fetchNow, callResponseHandlers, continueIncomplete, isRequest, mergeDuplicateRequests, searchRequestQueue, and courier notifier instance.
cjcenizal
force-pushed
the
make-refresh-explicit
branch
from
0306156 to
da8dd57
Compare
|
@timroes I cleaned up the diff. |
💔 Build Failed |
|
@cjcenizal - r u still working on it and want to keep it opened ? There hasn't been any activity here. |
💔 Build Failed |
|
Closing for now. Thanks for the ping @Rasroh! |
This is currently a POC which demonstrates ideas from #20364 (comment). SearchSource has been refactored to return the promise which resolves its search request, allowing for the removal of a lot of courier logic.