[ES|QL] Improves the comments color in dark mode #203965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
v8.17.0
v8.18.0
v9.0.0
Feature:ES|QL
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
added
the
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
|
vadimkibana
approved these changes
Dec 12, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12295163735 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Closes elastic#202152 Fixes the comments color in dark mode <img width="928" alt="image" src="https://github.com/user-attachments/assets/7d007cfa-f6d4-45e9-817d-57178c64d0a4" /> (cherry picked from commit 6921de3) # Conflicts: # packages/kbn-monaco/src/esql/lib/esql_theme.ts
stratoula
added a commit
that referenced
this pull request
Dec 13, 2024
…4055) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Improves the comments color in dark mode (#203965)](#203965) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-12-12T11:08:55Z","message":"[ES|QL] Improves the comments color in dark mode (#203965)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/202152\r\n\r\nFixes the comments color in dark mode \r\n\r\n<img width=\"928\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/7d007cfa-f6d4-45e9-817d-57178c64d0a4\"\r\n/>","sha":"6921de34988b43614438f7ca318ed9f3f109b1d7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.18.0"],"number":203965,"url":"https://github.com/elastic/kibana/pull/203965","mergeCommit":{"message":"[ES|QL] Improves the comments color in dark mode (#203965)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/202152\r\n\r\nFixes the comments color in dark mode \r\n\r\n<img width=\"928\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/7d007cfa-f6d4-45e9-817d-57178c64d0a4\"\r\n/>","sha":"6921de34988b43614438f7ca318ed9f3f109b1d7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203965","number":203965,"mergeCommit":{"message":"[ES|QL] Improves the comments color in dark mode (#203965)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/202152\r\n\r\nFixes the comments color in dark mode \r\n\r\n<img width=\"928\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/7d007cfa-f6d4-45e9-817d-57178c64d0a4\"\r\n/>","sha":"6921de34988b43614438f7ca318ed9f3f109b1d7"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary Closes elastic#202152 Fixes the comments color in dark mode <img width="928" alt="image" src="https://github.com/user-attachments/assets/7d007cfa-f6d4-45e9-817d-57178c64d0a4" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #202152
Fixes the comments color in dark mode