Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding indexPattern to agg so its not accessed from vis.indexPattern #20491

Merged
merged 1 commit into from
Jul 9, 2018
Merged

adding indexPattern to agg so its not accessed from vis.indexPattern #20491

merged 1 commit into from
Jul 9, 2018

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Jul 5, 2018 •
edited by rayafratkina
Loading

Part of #19813 effort

adding indexPattern to agg so its not accessed from vis.indexPattern

@ppisljar ppisljar added WIP Work in progress Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jul 5, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@ppisljar ppisljar force-pushed the fix/aggTypesRemoveVisIndexPattern branch from 3c94236 to 6258e49 Compare July 5, 2018 15:53
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ppisljar ppisljar added review v6.4.0 and removed WIP Work in progress labels Jul 5, 2018
@ppisljar ppisljar requested review from nreese, timroes and markov00 July 5, 2018 17:16
nreese
nreese approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review

@nreese
Copy link
Contributor

nreese commented Jul 5, 2018 •
edited
Loading

You may have missed one in
https://github.com/elastic/kibana/blob/master/src/ui/public/agg_response/point_series/_init_x_axis.js#L29

@ppisljar
Copy link
Member Author

ppisljar commented Jul 6, 2018

intentionally skipped, this is not the same AggConfig, agg.schema does not exist here, also point series response handler will be refactored in a separate PR

@ppisljar ppisljar removed the request for review from timroes July 9, 2018 14:06
markov00
markov00 approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.
Tested with date histogram , filters on coordinate maps and barcharts

@ppisljar ppisljar merged commit c66c0f1 into elastic:master Jul 9, 2018
ppisljar added a commit to ppisljar/kibana that referenced this pull request Jul 9, 2018
@ppisljar
adding indexPattern to agg so its not accessed from vis.indexPattern (e…
4e91818 
…lastic#20491)
@ppisljar ppisljar mentioned this pull request Jul 9, 2018
Merged
@ppisljar ppisljar deleted the fix/aggTypesRemoveVisIndexPattern branch July 9, 2018 14:31
ppisljar added a commit that referenced this pull request Jul 9, 2018
@ppisljar
adding indexPattern to agg so its not accessed from vis.indexPattern (#…
383437d 
…20491) (#20559)
@elasticmachine
Copy link
Contributor

💔 Build Failed

@ppisljar ppisljar restored the fix/aggTypesRemoveVisIndexPattern branch September 26, 2018 10:06
@timroes timroes mentioned this pull request Dec 12, 2018
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppisljar @elasticmachine @nreese @markov00