Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate surfacing of Courier errors to the consumer #21056

Closed
wants to merge 2 commits into from
Closed

Delegate surfacing of Courier errors to the consumer #21056

wants to merge 2 commits into from

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Jul 20, 2018 •
edited
Loading

These changes prevent search request errors from resulting in a fatal error (the original default behavior) and instead expects the consumer to choose how to surface the error. For example, Discover surfaces it as a notification.

TODO:

  • Catch and surface all courier errors in Discover
  • Catch and surface all courier errors in Visualize
  • Catch and surface all courier errors in Dashboard
  • Catch and surface all courier errors in Graph
  • Make sure this doesn't interfere with ML or APM

@cjcenizal cjcenizal added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v6.4.0 labels Jul 20, 2018
@cjcenizal cjcenizal changed the title Clarify fatal result of Courier request errors. Delegate surfacing of Courier errors to the consumer Jul 20, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal added the WIP Work in progress label Jul 23, 2018
@cjcenizal cjcenizal mentioned this pull request Jul 23, 2018
Merged
10 tasks
@epixa epixa added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.5.0 v7.0.0 labels Oct 25, 2018
@cjcenizal cjcenizal closed this Jan 31, 2019
@cjcenizal cjcenizal deleted the courier-errors branch January 31, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Team:Visualizations Visualization editors, elastic-charts and infrastructure WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjcenizal @elasticmachine @epixa @LeeDr