[Telemetry] Add canvas stats to Legacy telemetry bulk uploader #21103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
v7.0.0
Feature:Telemetry
v6.5.0
Team:Presentation
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
tsullivan
commented
Jul 24, 2018
| @@ -8,13 +8,15 @@ import { get, set, merge } from 'lodash'; | |||
| import { | |||
| KIBANA_SYSTEM_ID, | |||
| LOGSTASH_SYSTEM_ID, | |||
| CANVAS_SYSTEM_ID, | |||
There was a problem hiding this comment.
Changing this file should not have to be necessary
tsullivan
commented
Jul 24, 2018
| @@ -0,0 +1,62 @@ | |||
| /* | |||
There was a problem hiding this comment.
There isn't really anything "canvas" specific in this file. It was copied from the reporting file. Seems like it could be made generic at a higher level
|
I'm just going to go ahead and close this, because we'd rather have #21239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telemetry uses an internal Bulk Uploader, which is part of
x-pack/plugins/monitoring/server/kibana_monitoringto collect and upload stats to Elasticsearch in a method calledcombineStatsLegacy. This is legacy because the long-term goal is to have collection done externally through Metricbeat.This PR adds Canvas stats to the Bulk Uploader's payload data.