-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripted fields in Visualize #2124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w33ble
force-pushed
the
scripted-fields
branch
from
December 5, 2014 00:50
519b938
to
d0f3c0d
Compare
w33ble
force-pushed
the
scripted-fields
branch
from
December 5, 2014 00:53
d0f3c0d
to
d93f7ac
Compare
Currently this lets the user set the type to a variety of number formats. We don't actually use those in the app, rather just normalizing to "number" which should be sufficient. By this, I mean the script editor :-) |
I filed a couple new tickets on the field editor that @lukasolson is checking out. This, however, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scripted fields to the agg builder. Also handles situations where scripted fields are renamed or removed, via
redirectWhenMissing
params.field
as normal, scripted fields are appended asparams.script
matchAny
filter, which takes an array of criteria, any of which can match (uses _.some)