Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix IOException in java.time.LocalDateTime for painless script in ML Watch #21998

Merged
merged 1 commit into from
Aug 15, 2018
Merged

[ML] Fix IOException in java.time.LocalDateTime for painless script in ML Watch #21998

merged 1 commit into from
Aug 15, 2018

Conversation

jgowdyelastic
Copy link
Member

Fixes #18376

@jgowdyelastic jgowdyelastic self-assigned this Aug 15, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

peteharverson
peteharverson approved these changes Aug 15, 2018
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit 25e5a1e into elastic:master Aug 15, 2018
@jgowdyelastic jgowdyelastic mentioned this pull request Aug 15, 2018
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Aug 15, 2018
@jgowdyelastic
[ML] Fix painless script in ML watch (elastic#21998)
2d97fab
@jgowdyelastic jgowdyelastic changed the title [ML] Fix painless script in ML watch [ML] Fix IOException in java.time.LocalDateTime for painless script in ML Watch Aug 15, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

jgowdyelastic added a commit that referenced this pull request Aug 16, 2018
@jgowdyelastic
[ML] Fix painless script in ML watch (#21998) (#22014)
685aa37
cjcenizal pushed a commit to cjcenizal/kibana that referenced this pull request Aug 21, 2018
@jgowdyelastic @cjcenizal
[ML] Fix painless script in ML watch (elastic#21998)
9f49ed0
cjcenizal pushed a commit to cjcenizal/kibana that referenced this pull request Aug 23, 2018
@jgowdyelastic @cjcenizal
[ML] Fix painless script in ML watch (elastic#21998)
c846a73
@richcollier
Copy link

@jgowdyelastic - there is still a timezone issue with this fix. Specifically, the start and end times do not reference the timezone. As such, the anomaly explorer is pulled up for the wrong time period for most users. Therefore, there needs to be a :00.000Z added after the toString():

... ZoneOffset.UTC).toString()+\":00.000Z\""

jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Sep 3, 2018
@jgowdyelastic
[ML] Fix painless script in ML watch (elastic#21998)
d16c412
@jgowdyelastic jgowdyelastic mentioned this pull request Sep 3, 2018
Merged
jgowdyelastic added a commit that referenced this pull request Sep 4, 2018
@jgowdyelastic
[ML] Fix painless script in ML watch (#21998) (#22633)
8209490
@jgowdyelastic jgowdyelastic mentioned this pull request Sep 4, 2018
Merged
@lcawl lcawl added the bug Fixes for quality problems that affect the customer experience label Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml review v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @richcollier @peteharverson @spalger @lcawl