-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry] Have Telemetry automatically get all the Kibana usage stats #22336
[Telemetry] Have Telemetry automatically get all the Kibana usage stats #22336
Conversation
@pickypg this PR has the stats generated by Kibana's usage collectors generically added into a
Previously we had a module to collect reporting stats, and there is an overall combiner that fetches reporting stats and plugs it into the payload in an area we decided on. This setup isn't scalable as we need to add another module for each new integration. The obvious issue is this breaks the expected data that the telemetry web service receives. Can something be changed there so we can go with these changes? |
We can adjust the other side to handle the breaking changes if we must. Let's not get too harsh of an issue, but we should avoid continuing down this path for future telemetry and move to the new model in the future (for others reading this). |
retest |
💚 Build Succeeded |
@pickypg able to take a look for review? |
cc @elastic/kibana-platform anyone have some time to review this change to simplify the payload-generation side of telemetry? |
Maybe we can keep this conversation going. I get that it is a pain to add more mappings in the telemetry cluster for new features added into the data. But that's only half the pain, this PR addresses the caller's half of the pain of wiring new features into the data. I think I understand the new model better than I initially did. Am I right in thinking that the data could be fit into that model in a post-query phase? I'm pretty ok with how the usage collectors represent the data they fetch, but perhaps that data could be mapped right before getting transmitted to have an expressive structure where mapping on the other side would be automatic. |
💔 Build Failed |
I'm coming back to this as other work targeted for 6.5 depends on this. The update on this comment is that this PR is planned to be the last breaking thing we'll do for the telemetry upload data. |
💚 Build Succeeded |
💔 Build Failed |
re: #22336 (comment)
Correction/update: there will be no plugins nested under |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with latest tweak
…ts (elastic#22336) * Have Telemetry automatically get all the Kibana usage stats * simplify * remove reporting module * remove unused helper function * fix tests * fix integration tests * --wip-- [skip ci] * getKibanaStats flattens nested xpack plugin stats into a single level * fix integration test
…ts (#22336) (#24353) * Have Telemetry automatically get all the Kibana usage stats * simplify * remove reporting module * remove unused helper function * fix tests * fix integration tests * --wip-- [skip ci] * getKibanaStats flattens nested xpack plugin stats into a single level * fix integration test
Closes #21239
This change gets the telemetry data payload to automatically include any usage stat data that has been collected in the
.monitoring-kibana-*
indices.Note that Kibana telemetry still only works when Kibana Monitoring is turned on.