Allow filtering on multiple visualizations in the dashboard. #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late the maximum truncate length for x axis labels.
|
LGTM... I tested all the issues that appeared in #2255 and they seem to be fixed by this. |
|
This fixed the crash, but I still get an empty box. We should get a message here
|
|
@rashidkpc since this issue is related to the vislib not getting any data, I am not going to add another commit here to fix the issue above. I opened issue #2297. |
|
Ok, I'm fine merging this then given the new ticket. |
rashidkpc
added a commit
that referenced
this pull request
Dec 12, 2014
Allow filtering on multiple visualizations in the dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2255.
The issue reoccurred because a d3 selection did not exist in all cases. The fix here simply deletes that code. It isn't necessary and further complicates that particular function.
Tests still need to get in for this, but there is an open issue #2208.