Rollups i18n fixes and renamed ES interval errors #23796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cjcenizal
commented
Oct 3, 2018
cjcenizal
commented
- Remove the error in the Visualize sidebar added in Add rollupSearchStrategy #20505
- Fix i18n stuff
- Rename ES interval errors for brevity
…FormatError for brevity.
cjcenizal
force-pushed
the
rollups-crud-cr
branch
from
bfa2c1e to
10cc8d0
Compare
💔 Build Failed |
cjcenizal
added a commit
that referenced
this pull request
Oct 4, 2018
* Remove error callout from Visualize sidebar. * Rename errors to InvalidEsCalendarIntervalError and InvalidEsIntervalFormatError for brevity.
jen-huang
pushed a commit
that referenced
this pull request
Oct 17, 2018
* Remove error callout from Visualize sidebar. * Rename errors to InvalidEsCalendarIntervalError and InvalidEsIntervalFormatError for brevity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.