[Monitoring] Add tests to ensure mappings exist on metric fields #23958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
Merged in elastic/elasticsearch#34392 to fix all of these. |
|
retest |
💔 Build Failed |
💔 Build Failed |
|
retest |
💔 Build Failed |
💚 Build Succeeded |
|
@tsullivan Any chance you can look this week? |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 22, 2018
…stic#23958) * Ensure mappings exist * Add APM * Remove unnecessary eslint disable comment * Update snapshots
chrisronline
added a commit
that referenced
this pull request
Oct 23, 2018
) (#24333) * Ensure mappings exist * Add APM * Remove unnecessary eslint disable comment * Update snapshots
|
Backport: 6.x: 52043e0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #23862
NOTE: This will fail CI until the actual issues discovered are fixed.
While investigating #23862, it was discovered that some fields used for metric sets are not currently in the mappings (defined here). We need visibility into this so we can quickly react and fix so users aren't seeing empty graphs so this PR adds an api integration test that verifies all used metrics appear in appropriate mapping.
cc @ycombinator