-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: ingest node - add tag and update pipeline processor parameter #24400
Merged
jakelandis
merged 4 commits into
elastic:master
from
jakelandis:more_ingest_node_console
Oct 23, 2018
Merged
console: ingest node - add tag and update pipeline processor parameter #24400
jakelandis
merged 4 commits into
elastic:master
from
jakelandis:more_ingest_node_console
Oct 23, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcconaghy
approved these changes
Oct 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
11 tasks
💔 Build Failed |
retest |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
bmcconaghy
pushed a commit
to bmcconaghy/kibana
that referenced
this pull request
Oct 23, 2018
elastic#24400) * console: ingest node - add tag and update pipeline processor parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipeline processor parameter had a last minute change: elastic/elasticsearch#34733
Also, including the
tag
as part of the common parameters as I forgot about it on the last PR.EDIT: also included a fix for the script processor to autocomplete the non-deprecated parameter: https://www.elastic.co/guide/en/elasticsearch/reference/current/script-processor.html